You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/03/24 17:37:32 UTC

[GitHub] [arrow] alamb commented on a change in pull request #9773: ARROW-12028 ARROW-11940: [Rust][DataFusion] Add TimestampMillisecond support to GROUP BY/hash aggregates

alamb commented on a change in pull request #9773:
URL: https://github.com/apache/arrow/pull/9773#discussion_r600711837



##########
File path: rust/datafusion/src/physical_plan/group_scalar.rs
##########
@@ -63,6 +64,7 @@ impl TryFrom<&ScalarValue> for GroupByScalar {
             ScalarValue::UInt16(Some(v)) => GroupByScalar::UInt16(*v),
             ScalarValue::UInt32(Some(v)) => GroupByScalar::UInt32(*v),
             ScalarValue::UInt64(Some(v)) => GroupByScalar::UInt64(*v),
+            ScalarValue::TimeMillisecond(Some(v)) => GroupByScalar::TimeMillisecond(*v),

Review comment:
       Should we also add support for `ScalarValue::TimeMicrosecond` and `ScalarValue::TimeNanosecond`?
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org