You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/06/29 04:50:52 UTC

[I] Make PveResourceSpec hermetic so it stops running real pip install in the unit CI job [texera]

Yicong-Huang opened a new issue, #6023:
URL: https://github.com/apache/texera/issues/6023

   ### Task Summary
   
   `PveResourceSpec` runs in the `amber` unit CI job (`AMBER_TEST_FILTER=skip-integration`) but is **not** tagged `@IntegrationTest`, so every run shells out to real `pip` over the network:
   
   - Each `createNewPve` runs `pip install -r requirements.txt` (the full amber dependency set).
   - The lazy `resolveSystemPackages()` also installs `requirements.txt` into a throwaway venv, then `pip freeze`.
   
   That is ~6 full installs per spec run — network-dependent (flaky) and slow, on the PR-blocking unit path.
   
   **Fix:** funnel every child process in `PveManager` (venv creation, pip install/uninstall/freeze) through a single injectable `runProcess` seam (`PveManager` is an `object`). The spec swaps in a fake that fabricates the venv layout, emits canned output, and returns a configurable exit code — fully hermetic (no venv, no pip, no network). The metadata-file and queue-message logic stays under test, and failure paths (venv-create / install failures, system-package rejection) become cheap to cover.
   
   ### Task Type
   
   - [x] Refactor / Cleanup
   - [ ] DevOps / Deployment / CI
   - [x] Testing / QA
   - [ ] Documentation
   - [ ] Performance
   - [ ] Other
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Make PveResourceSpec hermetic so it stops running real pip install in the unit CI job [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6023:
URL: https://github.com/apache/texera/issues/6023#issuecomment-4829097440

   <!-- texera:template-compliance -->
   👋 Thanks for opening this issue, @Yicong-Huang!
   
   It looks like the issue description doesn't quite follow our template yet:
   
   - This issue doesn't appear to use one of our templates (Bug, Feature, or Task). Please open it using a template so the required details are captured.
   
   Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
   
   You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org