You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "Li-GL (via GitHub)" <gi...@apache.org> on 2024/09/25 16:33:29 UTC
[PR] [ZEPPELIN-6102]fix cron disabling and refresh issue [zeppelin]
Li-GL opened a new pull request, #4842:
URL: https://github.com/apache/zeppelin/pull/4842
### What is this PR for?
1. fix the cron disabling issue where zeppelin frontend was unable to diabling cron, i.e., after setting the cron, e.g., every 1m, 5m, when you change it to "None", it didn't take effect when you refresh the notebook.
2. fixes the cron refresh issue, i.e., when you update the cron setting, it always trigger the cron with the old cron expression, because the cron setting was refreshed before notebook updating.
### What type of PR is it?
Bug Fix
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-6102
### How should this be tested?
1. Open Zeppelin Web UI
2. Open any Notebook
3. Click the Cron Icon
4. set any cron expression
5. refresh the notebook and see if it worked as expected
6. set it to None
7. refresh the notebook and see if it worked as expected
### Screenshots (if appropriate)

### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6102]fix cron disabling and refresh issue [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4842:
URL: https://github.com/apache/zeppelin/pull/4842#issuecomment-2377136143
The code looks good to me. Can you write a unit test for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6102]fix cron disabling and refresh issue [zeppelin]
Posted by "Li-GL (via GitHub)" <gi...@apache.org>.
Li-GL commented on PR #4842:
URL: https://github.com/apache/zeppelin/pull/4842#issuecomment-2378336405
> The code looks good to me. Can you write a unit test for it?
Thanks for your review, the unit tests have been added and tested in a local development environment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org