You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/23 00:53:27 UTC

[GitHub] [spark] HeartSaVioR commented on a change in pull request #35816: [SPARK-38522][SS] Enrich the method contract of iterator in StateStore to not expect strong consistency on certain condition

HeartSaVioR commented on a change in pull request #35816:
URL: https://github.com/apache/spark/pull/35816#discussion_r832745981



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala
##########
@@ -126,7 +126,10 @@ trait StateStore extends ReadStateStore {
 
   /**
    * Return an iterator containing all the key-value pairs in the StateStore. Implementations must
-   * ensure that updates (puts, removes) can be made while iterating over this iterator.
+   * ensure that updates (puts, removes) can be made while iterating over this iterator, but it is

Review comment:
       Thanks for the suggestion! I'll reflect the change, and go merging since this is a nit comment.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org