You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "clownxc (via GitHub)" <gi...@apache.org> on 2023/03/29 16:01:03 UTC
[GitHub] [flink] clownxc opened a new pull request, #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
clownxc opened a new pull request, #22301:
URL: https://github.com/apache/flink/pull/22301
## What is the purpose of the change
Upgrade the deprecated UniqueConstraint to the new one
## Brief change log
- Upgrade the deprecated UniqueConstraint to the new one
## Verifying this change
This change is already covered by existing tests, such as *UniqueConstraintTest*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no )
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on PR #22301:
URL: https://github.com/apache/flink/pull/22301#issuecomment-1501027828
@clownxc Thanks for contribution. I'll have a look when i'm free
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] clownxc commented on pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
Posted by "clownxc (via GitHub)" <gi...@apache.org>.
clownxc commented on PR #22301:
URL: https://github.com/apache/flink/pull/22301#issuecomment-1490185991
> @clownxc Thanks for your work. I just left one minor comments.
>
> BTW, the CI failed.
Thank you so much for review. The reason for the CI failure is “You have 1 Checkstyle violation”. I will modify the code style to comply with Flink‘s rewuirements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22301:
URL: https://github.com/apache/flink/pull/22301#issuecomment-1488896013
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3c2c9cac042ac73076b7bba387a450f2a62e3a37",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3c2c9cac042ac73076b7bba387a450f2a62e3a37",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c2c9cac042ac73076b7bba387a450f2a62e3a37 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Aitozi commented on a diff in pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
Posted by "Aitozi (via GitHub)" <gi...@apache.org>.
Aitozi commented on code in PR #22301:
URL: https://github.com/apache/flink/pull/22301#discussion_r1155295984
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/api/TableSchemaTest.java:
##########
@@ -328,7 +328,7 @@ void testPrimaryKeyPrinting() {
+ " |-- f0: BIGINT NOT NULL\n"
+ " |-- f1: STRING NOT NULL\n"
+ " |-- f2: DOUBLE NOT NULL\n"
- + " |-- CONSTRAINT pk PRIMARY KEY (f0, f2)\n");
+ + " |-- CONSTRAINT `pk` PRIMARY KEY (`f0`, `f2`) NOT ENFORCED\n");
Review Comment:
Why this changed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] clownxc commented on pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
Posted by "clownxc (via GitHub)" <gi...@apache.org>.
clownxc commented on PR #22301:
URL: https://github.com/apache/flink/pull/22301#issuecomment-1495903365
I applied the suggested code changes.Can you please do another review @luoyuxia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] clownxc commented on pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
Posted by "clownxc (via GitHub)" <gi...@apache.org>.
clownxc commented on PR #22301:
URL: https://github.com/apache/flink/pull/22301#issuecomment-1490436003
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] clownxc commented on a diff in pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
Posted by "clownxc (via GitHub)" <gi...@apache.org>.
clownxc commented on code in PR #22301:
URL: https://github.com/apache/flink/pull/22301#discussion_r1155957023
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/api/TableSchemaTest.java:
##########
@@ -328,7 +328,7 @@ void testPrimaryKeyPrinting() {
+ " |-- f0: BIGINT NOT NULL\n"
+ " |-- f1: STRING NOT NULL\n"
+ " |-- f2: DOUBLE NOT NULL\n"
- + " |-- CONSTRAINT pk PRIMARY KEY (f0, f2)\n");
+ + " |-- CONSTRAINT `pk` PRIMARY KEY (`f0`, `f2`) NOT ENFORCED\n");
Review Comment:
there are some minor differences between the new and old APIs
```java
public final String asSummaryString() {
return String.format(
"CONSTRAINT %s %s (%s)%s",
EncodingUtils.escapeIdentifier(getName()),
getTypeString(),
columns.stream()
.map(EncodingUtils::escapeIdentifier)
.collect(Collectors.joining(", ")),
isEnforced() ? "" : " NOT ENFORCED");
}
```
The method `escapeIdentifier` of the new api adds a symbol `` to each field
```java
public static String escapeIdentifier(String s) {
return "`" + escapeBackticks(s) + "`";
}
```
@Aitozi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] clownxc commented on a diff in pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
Posted by "clownxc (via GitHub)" <gi...@apache.org>.
clownxc commented on code in PR #22301:
URL: https://github.com/apache/flink/pull/22301#discussion_r1155958077
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/api/TableSchemaTest.java:
##########
@@ -328,7 +328,7 @@ void testPrimaryKeyPrinting() {
+ " |-- f0: BIGINT NOT NULL\n"
+ " |-- f1: STRING NOT NULL\n"
+ " |-- f2: DOUBLE NOT NULL\n"
- + " |-- CONSTRAINT pk PRIMARY KEY (f0, f2)\n");
+ + " |-- CONSTRAINT `pk` PRIMARY KEY (`f0`, `f2`) NOT ENFORCED\n");
Review Comment:
there are some minor differences between the new and old APIs
```java
public final String asSummaryString() {
return String.format(
"CONSTRAINT %s %s (%s)%s",
EncodingUtils.escapeIdentifier(getName()),
getTypeString(),
columns.stream()
.map(EncodingUtils::escapeIdentifier)
.collect(Collectors.joining(", ")),
isEnforced() ? "" : " NOT ENFORCED");
}
```
The method `escapeIdentifier` of the new api adds a symbol `` to each field
```java
public static String escapeIdentifier(String s) {
return "`" + escapeBackticks(s) + "`";
}
```
@Aitozi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on code in PR #22301:
URL: https://github.com/apache/flink/pull/22301#discussion_r1152682771
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/constraints/UniqueConstraint.java:
##########
@@ -1,111 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.flink.table.api.constraints;
-
-import org.apache.flink.annotation.PublicEvolving;
-import org.apache.flink.table.catalog.ResolvedSchema;
-
-import java.util.List;
-import java.util.Objects;
-
-import static org.apache.flink.util.Preconditions.checkNotNull;
-
-/**
- * A unique key constraint. It can be declared also as a PRIMARY KEY.
- *
- * @see ConstraintType
- * @deprecated See {@link ResolvedSchema} and {@link
- * org.apache.flink.table.catalog.UniqueConstraint}.
- */
-@Deprecated
-@PublicEvolving
Review Comment:
+1. Share same concern. We must be cautious to dropping `@PublicEvolving` api.
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/constraints/UniqueConstraint.java:
##########
@@ -1,111 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.flink.table.api.constraints;
-
-import org.apache.flink.annotation.PublicEvolving;
-import org.apache.flink.table.catalog.ResolvedSchema;
-
-import java.util.List;
-import java.util.Objects;
-
-import static org.apache.flink.util.Preconditions.checkNotNull;
-
-/**
- * A unique key constraint. It can be declared also as a PRIMARY KEY.
- *
- * @see ConstraintType
- * @deprecated See {@link ResolvedSchema} and {@link
- * org.apache.flink.table.catalog.UniqueConstraint}.
- */
-@Deprecated
-@PublicEvolving
Review Comment:
+1. Share same concern. We must be cautious about dropping `@PublicEvolving` api.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] clownxc commented on pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
Posted by "clownxc (via GitHub)" <gi...@apache.org>.
clownxc commented on PR #22301:
URL: https://github.com/apache/flink/pull/22301#issuecomment-1488903242
can you spare some precious time to review? Thanks very much @Aitozi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] clownxc commented on a diff in pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
Posted by "clownxc (via GitHub)" <gi...@apache.org>.
clownxc commented on code in PR #22301:
URL: https://github.com/apache/flink/pull/22301#discussion_r1153161683
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/constraints/UniqueConstraint.java:
##########
@@ -1,111 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.flink.table.api.constraints;
-
-import org.apache.flink.annotation.PublicEvolving;
-import org.apache.flink.table.catalog.ResolvedSchema;
-
-import java.util.List;
-import java.util.Objects;
-
-import static org.apache.flink.util.Preconditions.checkNotNull;
-
-/**
- * A unique key constraint. It can be declared also as a PRIMARY KEY.
- *
- * @see ConstraintType
- * @deprecated See {@link ResolvedSchema} and {@link
- * org.apache.flink.table.catalog.UniqueConstraint}.
- */
-@Deprecated
-@PublicEvolving
Review Comment:
> +1. Share same concern. We must be cautious about dropping `@PublicEvolving` api.
Thank you so much for review. I will rollback '@ PublicEvolving' api Delete operation @luoyuxia @Aitozi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] clownxc commented on a diff in pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
Posted by "clownxc (via GitHub)" <gi...@apache.org>.
clownxc commented on code in PR #22301:
URL: https://github.com/apache/flink/pull/22301#discussion_r1155962586
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/api/TableSchemaTest.java:
##########
@@ -328,7 +328,7 @@ void testPrimaryKeyPrinting() {
+ " |-- f0: BIGINT NOT NULL\n"
+ " |-- f1: STRING NOT NULL\n"
+ " |-- f2: DOUBLE NOT NULL\n"
- + " |-- CONSTRAINT pk PRIMARY KEY (f0, f2)\n");
+ + " |-- CONSTRAINT `pk` PRIMARY KEY (`f0`, `f2`) NOT ENFORCED\n");
Review Comment:
this is the deprecated UniqueConstraint
```java
public final String asSummaryString() {
final String typeString;
switch (getType()) {
case PRIMARY_KEY:
typeString = "PRIMARY KEY";
break;
case UNIQUE_KEY:
typeString = "UNIQUE";
break;
default:
throw new IllegalStateException("Unknown key type: " + getType());
}
return String.format(
"CONSTRAINT %s %s (%s)", getName(), typeString, String.join(", ", columns));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Aitozi commented on a diff in pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
Posted by "Aitozi (via GitHub)" <gi...@apache.org>.
Aitozi commented on code in PR #22301:
URL: https://github.com/apache/flink/pull/22301#discussion_r1152652365
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/constraints/UniqueConstraint.java:
##########
@@ -1,111 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.flink.table.api.constraints;
-
-import org.apache.flink.annotation.PublicEvolving;
-import org.apache.flink.table.catalog.ResolvedSchema;
-
-import java.util.List;
-import java.util.Objects;
-
-import static org.apache.flink.util.Preconditions.checkNotNull;
-
-/**
- * A unique key constraint. It can be declared also as a PRIMARY KEY.
- *
- * @see ConstraintType
- * @deprecated See {@link ResolvedSchema} and {@link
- * org.apache.flink.table.catalog.UniqueConstraint}.
- */
-@Deprecated
-@PublicEvolving
Review Comment:
I'm afraid we can't directly remove this `@PublicEvolving` API. CC @luoyuxia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] clownxc commented on a diff in pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…
Posted by "clownxc (via GitHub)" <gi...@apache.org>.
clownxc commented on code in PR #22301:
URL: https://github.com/apache/flink/pull/22301#discussion_r1155957023
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/api/TableSchemaTest.java:
##########
@@ -328,7 +328,7 @@ void testPrimaryKeyPrinting() {
+ " |-- f0: BIGINT NOT NULL\n"
+ " |-- f1: STRING NOT NULL\n"
+ " |-- f2: DOUBLE NOT NULL\n"
- + " |-- CONSTRAINT pk PRIMARY KEY (f0, f2)\n");
+ + " |-- CONSTRAINT `pk` PRIMARY KEY (`f0`, `f2`) NOT ENFORCED\n");
Review Comment:
there are some minor differences between the new and old APIs
```java
public final String asSummaryString() {
return String.format(
"CONSTRAINT %s %s (%s)%s",
EncodingUtils.escapeIdentifier(getName()),
getTypeString(),
columns.stream()
.map(EncodingUtils::escapeIdentifier)
.collect(Collectors.joining(", ")),
isEnforced() ? "" : " NOT ENFORCED");
}
```
The method `escapeIdentifier` of the new api adds a symbol `` to each field
```java
public static String escapeIdentifier(String s) {
return "`" + escapeBackticks(s) + "`";
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org