You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2023/04/07 14:12:15 UTC
[GitHub] [beam] damccorm opened a new issue, #26168: [Bug]: multi_process_shared.py should not provide a default tag value
damccorm opened a new issue, #26168:
URL: https://github.com/apache/beam/issues/26168
### What happened?
Right now, MultiProcessShared accepts a tag input - https://github.com/apache/beam/blob/1a52deb9b9c0ac38aae1ebe8f085359149ac42c3/sdks/python/apache_beam/utils/multi_process_shared.py#L171 - that is set to None by default.
When the tag is set to None, it is set to a random value - https://github.com/apache/beam/blob/1a52deb9b9c0ac38aae1ebe8f085359149ac42c3/sdks/python/apache_beam/utils/multi_process_shared.py#L179 - since each process picks a different value, the object is not actually shared across processes (a shared instance of the object is instead created for each individual process).
Tag should not be None by default and probably should not even be optional since this is a misleading behavior. Note that this will be a breaking change for some users (if there are any), but those users are probably relying on buggy behavior anyways.
### Issue Priority
Priority: 2 (default / most bugs should be filed as P2)
### Issue Components
- [X] Component: Python SDK
- [ ] Component: Java SDK
- [ ] Component: Go SDK
- [ ] Component: Typescript SDK
- [ ] Component: IO connector
- [ ] Component: Beam examples
- [ ] Component: Beam playground
- [ ] Component: Beam katas
- [ ] Component: Website
- [ ] Component: Spark Runner
- [ ] Component: Flink Runner
- [ ] Component: Samza Runner
- [ ] Component: Twister2 Runner
- [ ] Component: Hazelcast Jet Runner
- [ ] Component: Google Cloud Dataflow Runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm closed issue #26168: [Bug]: multi_process_shared.py should not provide a default tag value
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed issue #26168: [Bug]: multi_process_shared.py should not provide a default tag value
URL: https://github.com/apache/beam/issues/26168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org