You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/18 01:05:15 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39098: [SPARK-41553][PS][PYTHON][CORE] Change `num_files` to `repartition`

HyukjinKwon commented on code in PR #39098:
URL: https://github.com/apache/spark/pull/39098#discussion_r1051506753


##########
python/pyspark/pandas/generic.py:
##########
@@ -694,7 +694,7 @@ def to_csv(
         escapechar: str, default None
             String of length 1. Character used to escape `sep` and `quotechar`
             when appropriate.
-        num_files: the number of files to be written in `path` directory when
+        repartition: the number of files to be written in `path` directory when

Review Comment:
   I think we should just remove this out in the future, and let users to use DataFrame.spark.repartition instead .. instead of adding a new renamed parameter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org