You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/01/28 06:26:25 UTC

[GitHub] [phoenix] stoty commented on a change in pull request #1118: PHOENIX-6343 : Phoenix allows duplicate column names when one of them is a primary key

stoty commented on a change in pull request #1118:
URL: https://github.com/apache/phoenix/pull/1118#discussion_r565847549



##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/CreateTableIT.java
##########
@@ -90,6 +91,66 @@ public void testStartKeyStopKey() throws SQLException {
         assertTrue(splits.size() > 0);
     }
 
+    @Test

Review comment:
       Can you add a test for adding the identical column with an alter table statement ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org