[GitHub] [flink] xintongsong commented on a change in pull request #9106: [FLINK-13184][yarn] Support launching task executors with multi-thread on YARN.

[GitBox <gi...@apache.org>]

xintongsong commented on a change in pull request #9106: [FLINK-13184][yarn] Support launching task executors with multi-thread on YARN.
URL: https://github.com/apache/flink/pull/9106#discussion_r306133278
 
 

 ##########
 File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
 ##########
 @@ -131,6 +137,11 @@
 
 	private final Resource resource;
 
+	/**
+	 * Executor for starting new yarn containers.
+	 */
+	private final Executor startContainerExecutor;
 
 Review comment:
   I would rather keep it the current way, for 2 reasons.
   1. It does not cause any resource leak. The `ThreadPoolExecutor` is configured that pooled threads will be terminated if there's no tasks for 60s, and the executor itself is shutdown automatically if there is no remaining threads and it is no longer referenced.
   2. The general `Executor` interface does not have a `shutdown` method. And I would like to keep the thread pool declared in the general type `Executor`, in case later we want to use a different executor implementation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services