[GitHub] [echarts] chfw commented on a change in pull request #13788: feat(colorBy): provide option.colorBy #13731

[GitBox <gi...@apache.org>]

chfw commented on a change in pull request #13788:
URL: https://github.com/apache/echarts/pull/13788#discussion_r661778812



##########
File path: src/util/types.ts
##########
@@ -850,6 +850,19 @@ export interface BorderOptionMixin {
     borderMiterLimit?: number
 }
 
+export type ColorBy = 'seriesName' | 'seriesIndex' | 'seriesId' | 'name' | 'dataIndex' | 'id';
+
+// Sunburst color mapping on levels and items are yet to be implemented
+// export type SunburstColorBy = ColorBy | 'inherit' | 'childIndex' | 'lighter';

Review comment:
       To-be-implemented feature can stay in its own feature branch. Commented code is dead code and is a noise. Git will help you merge changes from dev branch.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org