[GitHub] [hbase-filesystem] mackrorysd commented on a change in pull request #1: HBASE-22149. HBOSS: A FileSystem implementation to provide HBase's re…

[GitBox <gi...@apache.org>]

mackrorysd commented on a change in pull request #1: HBASE-22149. HBOSS: A FileSystem implementation to provide HBase's re…
URL: https://github.com/apache/hbase-filesystem/pull/1#discussion_r280080915
 
 

 ##########
 File path: hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/Constants.java
 ##########
 @@ -18,9 +18,11 @@
 
 package org.apache.hadoop.hbase.oss;
 
-import org.apache.hadoop.classification.InterfaceAudience;
-import org.apache.hadoop.classification.InterfaceStability;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
 
+@InterfaceAudience.LimitedPrivate({"HBase"})
 
 Review comment:
   The design allows HBase to call "new HBaseObjectStoreSemantics("s3a://bucket/", conf)" and eliminate the need for any of the *.impl configs. But to avoid code changes I've been testing by using configs to inject HBOSS into that layer. So both - but I'm not opposed to just requiring one approach or the other to make things simpler if the HBase community has a strong preference for one.
   
   I'm a little torn on how the TreeLockManager implementations should be annotated - they're intended to be referenced directly by users in configs, but people should be calling the functions directly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services