You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by md...@apache.org on 2014/12/17 15:33:22 UTC

svn commit: r1646264 - /jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/OakBaseTest.java

Author: mduerig
Date: Wed Dec 17 14:33:22 2014
New Revision: 1646264

URL: http://svn.apache.org/r1646264
Log:
OAK-2365: Refactor node store tests
Also run the tests against the memory node store

Modified:
    jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/OakBaseTest.java

Modified: jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/OakBaseTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/OakBaseTest.java?rev=1646264&r1=1646263&r2=1646264&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/OakBaseTest.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/OakBaseTest.java Wed Dec 17 14:33:22 2014
@@ -37,6 +37,7 @@ public abstract class OakBaseTest {
                 {NodeStoreFixture.MONGO_MK},
                 {NodeStoreFixture.MONGO_NS},
                 {NodeStoreFixture.SEGMENT_MK},
+                {NodeStoreFixture.MEMORY_NS},
         };
         return Arrays.asList(fixtures);
     }

Travis build failure (was Re: svn commit: r1646264 - ...)

Posted by Davide Giannella <da...@apache.org>.
> PS: just noted that travis has been failing for a while now. We should
> restore the notifications...

https://issues.apache.org/jira/browse/OAK-2370

o.a.j.o.plugins.segment.HeavyWriteIT fails on travis (exit code 137)

Davide

Re: svn commit: r1646264 - /jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/OakBaseTest.java

Posted by Davide Giannella <da...@apache.org>.
On 18/12/2014 16:05, Michael Dürig wrote:
>
> On 18.12.14 9:56 , Davide Giannella wrote:
>> Don't know if it's really your case; but some time ago we created the
>> /oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/FixturesHelper.java
>> to help and centralise the available fixtures so that could later on
>> split the build (in Travis) based on fixtures.
>>
>> worth a check as you're on the way. :)
>
> Right,forgot about that one. The problem is however that the fixture
> helper is in oak-jcr and those tests are in oak-core. Also the tests
> are more unit test like and run quite fast, so for the time being I
> don't see much need for action here.
Feel free to move around the FixturesHelper. It makes actually more
sense to have it in core available to everyone.

If we instruct already all the testing where possible (including unit)
to be fixture aware it will help us later on in a further splits of the
build on travis. Our unittesting profile is anyhow one of the longest one ;)

Davide

PS: just noted that travis has been failing for a while now. We should
restore the notifications...

Re: svn commit: r1646264 - /jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/OakBaseTest.java

Posted by Michael Dürig <md...@apache.org>.
On 18.12.14 9:56 , Davide Giannella wrote:
> Don't know if it's really your case; but some time ago we created the
> /oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/FixturesHelper.java
> to help and centralise the available fixtures so that could later on
> split the build (in Travis) based on fixtures.
>
> worth a check as you're on the way. :)

Right,forgot about that one. The problem is however that the fixture 
helper is in oak-jcr and those tests are in oak-core. Also the tests are 
more unit test like and run quite fast, so for the time being I don't 
see much need for action here.

Michael

Re: svn commit: r1646264 - /jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/OakBaseTest.java

Posted by Davide Giannella <da...@apache.org>.
On 17/12/2014 14:33, mduerig@apache.org wrote:
> Author: mduerig
> Date: Wed Dec 17 14:33:22 2014
> New Revision: 1646264
>
> URL: http://svn.apache.org/r1646264
> Log:
> OAK-2365: Refactor node store tests
> Also run the tests against the memory node store
>
> Modified:
>     jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/OakBaseTest.java
>
> Modified: jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/OakBaseTest.java
> URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/OakBaseTest.java?rev=1646264&r1=1646263&r2=1646264&view=diff
> ==============================================================================
> --- jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/OakBaseTest.java (original)
> +++ jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/OakBaseTest.java Wed Dec 17 14:33:22 2014
> @@ -37,6 +37,7 @@ public abstract class OakBaseTest {
>                  {NodeStoreFixture.MONGO_MK},
>                  {NodeStoreFixture.MONGO_NS},
>                  {NodeStoreFixture.SEGMENT_MK},
> +                {NodeStoreFixture.MEMORY_NS},
>          };
>          return Arrays.asList(fixtures);
>
Don't know if it's really your case; but some time ago we created the
/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/FixturesHelper.java
to help and centralise the available fixtures so that could later on
split the build (in Travis) based on fixtures.

worth a check as you're on the way. :)

Cheers
Davide