[GitHub] [nifi] thenatog commented on a diff in pull request #6400: NIFI-10481 Add NiFi configuration to disable zk client ensembleTracker

[GitBox <gi...@apache.org>]

thenatog commented on code in PR #6400:
URL: https://github.com/apache/nifi/pull/6400#discussion_r1003937995


##########
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java:
##########
@@ -1707,6 +1709,17 @@ public boolean isZooKeeperClientSecure() {
         return Boolean.parseBoolean(clientSecure);
     }
 
+    public boolean isZookeeperClientWithEnsembleTracker() {
+        final String defaultValue = String.valueOf(DEFAULT_ZOOKEEPER_CLIENT_ENSEMBLE_TRACKER);
+        final String withEnsembleTracker = getProperty(ZOOKEEPER_CLIENT_ENSEMBLE_TRACKER, defaultValue).trim();
+
+        if (!"true".equalsIgnoreCase(withEnsembleTracker) && !"false".equalsIgnoreCase(withEnsembleTracker)) {

Review Comment:
   _Boolean.valueOf()_ can be used instead of comparing against 'true' and 'false' literal string values.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org