You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stephen Mallette (Jira)" <ji...@apache.org> on 2020/08/13 11:21:00 UTC
[jira] [Comment Edited] (CASSANDRA-15788) Add tests to cover
CacheMetrics
[ https://issues.apache.org/jira/browse/CASSANDRA-15788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176933#comment-17176933 ]
Stephen Mallette edited comment on CASSANDRA-15788 at 8/13/20, 11:20 AM:
-------------------------------------------------------------------------
I resolved the bad brace formatting:
https://github.com/apache/cassandra/compare/trunk...spmallette:CASSANDRA-15788-trunk
I kept the public access to {{CacheMetrics.reset()}} since it was being accessed by {{ChunkCache}} outside of the package (also only from a {{VisibleForTesting}} perspective)
was (Author: spmallette):
I resolved the bad brace formatting:
https://github.com/apache/cassandra/compare/trunk...spmallette:CASSANDRA-15788-trunk
I kept the public access to {{CacheMetrics.reset()}} since it was being accessed by {{ChunkCache}} outside of the package.
> Add tests to cover CacheMetrics
> -------------------------------
>
> Key: CASSANDRA-15788
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15788
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Normal
>
> {{CacheMetrics}} and {{ChunkCacheMetrics}} do not have unit tests covering them. {{CachingBench}} seems to provide some coverage but those tests (which don't appear to run as part of the standard run of unit tests) are failing and do not assert against all defined metrics, nor do they seem to assert code in {{InstrumentingCache}} which also incremented metrics.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org