Re: [PR] Change the implementation of Admin#getServerNodes() to support carrying ServerTag [fluss]

["affo (via GitHub)" <gi...@apache.org>]

affo commented on code in PR #1410:
URL: https://github.com/apache/fluss/pull/1410#discussion_r3829311082


##########
fluss-server/src/main/java/org/apache/fluss/server/RpcServiceBase.java:
##########
@@ -712,4 +730,40 @@ private boolean isPartitionAssignmentMissingFromZk(long partitionId) {
             return false;
         }
     }
+
+    protected DescribeClusterResponse makeDescribeClusterResponse(
+            String listenerName, ServerMetadataCache metadataCache) {
+        ServerNode coordinatorServer = metadataCache.getCoordinatorServer(listenerName);
+
+        Collection<ServerNode> aliveTabletServers =
+                metadataCache.getAllAliveTabletServers(listenerName).values();
+        Set<ServerNode> aliveTabletServersWithTag = new HashSet<>(aliveTabletServers.size());
+        try {
+            Optional<ServerTags> serverTagsOp = zkClient.getServerTags();

Review Comment:
   Why not getting this out of the existing `CoordinatorMetadataCache`?
   It would avoid a blocking call and fetch directly from memory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org