[GitHub] [beam] TheNeuralBit commented on pull request #13428: [BEAM-11338] Beam schema for thrift data

[GitBox <gi...@apache.org>]

TheNeuralBit commented on pull request #13428:
URL: https://github.com/apache/beam/pull/13428#issuecomment-743464814


   > I guess what you're saying is that the right approach would be to make use of some BeamKafkaThriftTable extending BeamKafkaTable and just read/write bytes from/to Kafka. 
   
   Yes exactly! Ideally we'd add similar support for PubSub, but as it stands that will require duplicating code.
   
   > So do expect a follow-up PR, unless you think this schema provider alone does not really deserve to be merged by itself. I will also have a closer look at the current abstractions and file Jiras for potential improvements if I'll be able to come up with 
   any.
   
   Oh this PR is certainly useful on it's own! I just wanted to gauge the need for further work. If you'd like to build on this I can help point you in the right direction.
   
   > P.S. as a side joke: you misspelled my name in a way that also changes my gender (at least in my native language), but it sounds so funny that I'm thinking of changing my username to that. :)
   
   Ah I'm so sorry! I guess typing "data" is very strong in my muscle memory


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org