You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "jvenant (via GitHub)" <gi...@apache.org> on 2023/09/01 10:16:52 UTC
[GitHub] [pinot] jvenant opened a new issue, #11483: HTTP 1.1 authentication challenge
jvenant opened a new issue, #11483:
URL: https://github.com/apache/pinot/issues/11483
Pinot broker doesn't follow the HTTP 1.1 authentication challenge standard.
The workflow is describe here : https://developer.mozilla.org/en-US/docs/Web/HTTP/Authentication
and is also used by the java standard HttpClient.
It prevents from correctly authenticate to the broker using code like this :
```kotlin
val request = HttpRequest.newBuilder(URI.create("https://secured_broker:8099/query/sql"))
.header("Content-Type", "application/json")
.header("Accept", "application/json")
.build()
val client = HttpClient.newBuilder()
.authenticator(object: Authenticator(){
override fun getPasswordAuthentication() = PasswordAuthentication("login", "password".toCharArray())
})
.build()
val result = client.send(request, HttpResponse.BodyHandlers.ofInputStream())
print(result)
```
Java client first try the request without Authorization header. And then resend the request with the Authorization in case of 401.
Currently, broker seems to only return 403 Http code which is a dead end from the java client perspective
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] soumitra-st commented on issue #11483: HTTP 1.1 authentication challenge
Posted by "soumitra-st (via GitHub)" <gi...@apache.org>.
soumitra-st commented on issue #11483:
URL: https://github.com/apache/pinot/issues/11483#issuecomment-1716030378
@jvenant , Great find! What is the AccessControlFactory set to in the test environment? [Broker request filter](https://github.com/apache/pinot/blob/61dcea6b71a99746805bc7f322daed67f9bce265/pinot-broker/src/main/java/org/apache/pinot/broker/broker/AuthenticationFilter.java#L48) calls hasAccess methods to check for authn, and authz, we should change the code in there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #11483: HTTP 1.1 authentication challenge
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #11483:
URL: https://github.com/apache/pinot/issues/11483#issuecomment-1703391819
Thanks for reporting the issue. Would you like to help contribute a fix for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org