[GitHub] [tinkerpop] FlorianHockmann commented on issue #1250: fix for https://issues.apache.org/jira/browse/TINKERPOP-2192

[GitBox <gi...@apache.org>]

FlorianHockmann commented on issue #1250: fix for https://issues.apache.org/jira/browse/TINKERPOP-2192
URL: https://github.com/apache/tinkerpop/pull/1250#issuecomment-594631143
 
 
   I agree with the points you made, @spmallette. I simply forgot to check those during the review.
   
   > This change targets master - should it target an earlier branch? I'd guess it should at least target 3.4-dev but perhaps it should even go back to 3.3-dev?
   
   Yes, you're right. It should target `3.4-dev` in my opinion. `3.3-dev` would also be possible, but would require a different PR as this part of the driver has changed a lot between 3.3 and 3.4. Since the download numbers for 3.3 releases are very low for Gremlin.Net (only 67 downloads for 3.3.10 and 107 for 3.3.9 right now), I don't think it's worth the effort to backport a small fix like this to `3.3-dev`.
   @dzmitry-lahoda We'll merge the change into `3.4-dev` and then merge that branch into `master` if you change the target branch here to `3.4-dev`. That way, the change will land in the next 3.4 release (probably 3.4.7) and also in 3.5.0, whenever that will be released.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services