You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Chun-Hung Hsiao (JIRA)" <ji...@apache.org> on 2019/03/05 03:32:00 UTC
[jira] [Commented] (MESOS-9565) Unit tests for destroying
persistent volumes in SLRP.
[ https://issues.apache.org/jira/browse/MESOS-9565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784023#comment-16784023 ]
Chun-Hung Hsiao commented on MESOS-9565:
----------------------------------------
Committed the following patches:
{noformat}
commit bf3982d8d143e7a4d928047a4f7dec9d69479235
Author: Chun-Hung Hsiao <ch...@mesosphere.io>
Date: Thu Jan 31 14:32:54 2019 -0800
Made SLRP `PublishResources` test to check persistent volume cleanup.
This patch renames the `ROOT_PublishResources` test to
`ROOT_CreateDestroyPersistentMountVolume` and makes it verify that the
persistent volume is cleaned up after `DESTROY`.
NOTE: The `filesystem/linux` isolator has been removed from the test
because it is not necessary for the test. However, the root privilege is
still required by the test CSI plugin for bind-mounting.
Review: https://reviews.apache.org/r/69895{noformat}
{noformat}
commit 8aaf50291f8cc601cf1742dfca610bd27bc897f4
Author: Chun-Hung Hsiao <ch...@mesosphere.io>
Date: Thu Jan 31 19:05:48 2019 -0800
Made SLRP `PublishResourcesReboot` test to check persistent volume cleanup.
This patch renames the `ROOT_PublishResourcesReboot` test to
`ROOT_CreateDestroyPersistentMountVolumeWithReboot` and makes it verify
that the persistent volume is cleaned up with `DESTROY` after a reboot.
NOTE: The `filesystem/linux` isolator has been removed from the test
because it is not necessary for the test. However, the root privilege is
still required by the test CSI plugin for bind-mounting.
Review: https://reviews.apache.org/r/69896{noformat}
{noformat}
commit a6effff757467d6443ccc1328a65cd3e36aaa871
Author: Chun-Hung Hsiao <ch...@mesosphere.io>
Date: Fri Feb 1 17:01:06 2019 -0800
Made SLRP `PublishResourcesRecovery` test to check volume cleanup.
This patch renames the `ROOT_PublishResourcesRecovery` test to
`ROOT_CreateDestroyPersistentMountVolumeWithRecovery` and makes it
verify that the persistent volume is cleaned up with `DESTROY` after
recovery.
NOTE: The `filesystem/linux` isolator has been removed from the test
because it is not necessary for the test. However, the root privilege is
still required by the test CSI plugin for bind-mounting.
Review: https://reviews.apache.org/r/69897{noformat}
{noformat}
commit 6b05bc8c05c1951999ea787ffb9c1815bb5ef8b4
Author: Chun-Hung Hsiao <ch...@mesosphere.io>
Date: Mon Feb 4 16:38:50 2019 -0800
Updated `CreateDestroyDisk*` SLRP tests to test pipelined operations.
This patch extends the code coverage of the `CreateDestroyDisk` and
`CreateDestroyDiskRecovery` tests by testing pipelined `RESERVE`,
`CREATE`, `DESTROY` and `UNRESERVE` operations along with `CREATE_DISK`
and `DESTROY_DISK`. It also renames `CreateDestroyDiskRecovery` to
`CreateDestroyDiskWithRecovery` for consistency.
Review: https://reviews.apache.org/r/69898{noformat}
{noformat}
commit 43bf73ca2f902356c3a5b92fb7cf535af3b7ccc4
Author: Chun-Hung Hsiao <ch...@mesosphere.io>
Date: Tue Feb 5 21:23:23 2019 -0800
Extracted common offer matching functions from SLRP tests.
This patch extracts lambda functions `isStoragePool`, `isMountDisk` and
`isPreprovisionedVolume` from all tests and makes them common utitily
functions in the test fixture.
Review: https://reviews.apache.org/r/69904{noformat}
{noformat}
commit 069ac8ab9f298d11344accc964120103ba84ddbd
Author: Chun-Hung Hsiao <ch...@mesosphere.io>
Date: Thu Jan 31 16:19:43 2019 -0800
Added a SLRP unit test for failed persistent volume cleanup.
Test `ROOT_CreateDestroyPersistentMountVolumeFailed` verifies that if
SLRP fails to clean up a persistent volume, `DESTROY` would fail, the
persistent volume would remain, and depended operations will be dropped.
Review: https://reviews.apache.org/r/69905{noformat}
{noformat}
commit 069ac8ab9f298d11344accc964120103ba84ddbd
Author: Chun-Hung Hsiao <ch...@mesosphere.io>
Date: Thu Jan 31 16:19:43 2019 -0800
Added a SLRP unit test for failed persistent volume cleanup.
Test `ROOT_CreateDestroyPersistentMountVolumeFailed` verifies that if
SLRP fails to clean up a persistent volume, `DESTROY` would fail, the
persistent volume would remain, and depended operations will be dropped.
Review: https://reviews.apache.org/r/69905{noformat}
> Unit tests for destroying persistent volumes in SLRP.
> -----------------------------------------------------
>
> Key: MESOS-9565
> URL: https://issues.apache.org/jira/browse/MESOS-9565
> Project: Mesos
> Issue Type: Task
> Components: test
> Reporter: Chun-Hung Hsiao
> Assignee: Chun-Hung Hsiao
> Priority: Major
> Labels: mesosphere, storage
>
> The plan is to add/update the following unit tests to test persistent volume destroy:
> * CreateDestroyDisk
> * CreateDestroyDiskWithRecovery
> * CreateDestroyPersistentMountVolume
> * CreateDestroyPersistentMountVolumeWithRecovery
> * CreateDestroyPersistentMountVolumeWithReboot
> * CreateDestroyPersistentBlockVolume
> * DestroyPersistentMountVolumeFailed
> * DestroyUnpublishedPersistentVolume
> * DestroyUnpublishedPersistentVolumeWithRecovery
> * DestroyUnpublishedPersistentVolumeWithReboot
> * RecoverPublishedPersistentVolumeFailed
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)