You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@httpd.apache.org by Leif W <wa...@usa.net> on 2004/12/06 08:54:30 UTC

[users@httpd] [PATCH] suexec group name & SSLPassPhraseDialog port

Hello,

I've submitted two extremely simple patches (3-5 lines each) to Bugzilla
several weeks ago, and notified the dev list, but the devs have been
busy elsewhere.  In an effort to get some interest and action on these
two exceedlingly simple patches, I thought I'd post a note here.

* suexec never log a group name.
  http://issues.apache.org/bugzilla/show_bug.cgi?id=7862

* SSLPassPhraseDialog exec: always default port in argv
  http://issues.apache.org/bugzilla/show_bug.cgi?id=24331

These two bugs and their patches are arguably trivial.  So this should
be all the more reason to fix it.  :p

One I wouldn't argue much, the suexec patch, it's mostly cosmetic.  But
if it makes my logs slightly more easy to read, and furthermore returns
a consistency to the way that the numeric user id and alphanumeric user
name are presented, then it is worthwhile.

The SSLPassPhraseDialog will affect anyone who uses SSL on the same IP
address, onthe same hostname, with two different ports.  This is
probably a very small group of people who would even understand why you
might want to (or be so limited and need to) do such a thing, let alone
anyone who actually uses the technique.  Nonetheless, is this an excuse
to leave code broken which might someday ruin someone's day, when the
fix is so trivial?

I have no idea what the heck I am doing.  I mean come on, me, patch
something?  :p  That's why I need some people to get the latest 2.0.x or
2.1.x releases, or 2.0 or 2.1 HEAD from SVN, and try to apply these
patches, observe the results, and hit me over the head if I
inadvertently opened up the gates of hell (again).

Go to the bug's page, read about the bugs, understand what's going on,
observe and verify the same error, apply the patch, observe the remedy,
check for any conceivable problem that may exist with mypatch, and most
importantly, update the bug entry with your results (good and bad),
maybe even vote for it, then go to the mailing list archives, dig up my
old dev messages, and reply to them.

You could patch it with one finger, it's so easy.  ;-)

Thank you!

Leif




---------------------------------------------------------------------
The official User-To-User support forum of the Apache HTTP Server Project.
See <URL:http://httpd.apache.org/userslist.html> for more info.
To unsubscribe, e-mail: users-unsubscribe@httpd.apache.org
   "   from the digest: users-digest-unsubscribe@httpd.apache.org
For additional commands, e-mail: users-help@httpd.apache.org