You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/07/12 20:07:22 UTC
[GitHub] [netbeans] sdedic commented on a change in pull request #3042: Optionally disable groovy support in NBJLS
sdedic commented on a change in pull request #3042:
URL: https://github.com/apache/netbeans/pull/3042#discussion_r668149889
##########
File path: java/java.lsp.server/vscode/package.json
##########
@@ -84,6 +84,11 @@
"type": "boolean",
"default": false,
"description": "Enable Run/Debug test in editor"
+ },
+ "netbeans.groovySupport.enabled": {
Review comment:
Not yet. Should we ever fix it / document it, if we believe we can improve things during 12.5 release ?
##########
File path: groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/utils/GroovyUtils.java
##########
@@ -236,4 +236,25 @@ private static String stripPackageFromTypeParams(String params) {
}
return sb.toString();
}
+
+ /**
+ * True, if the indexing is enabled. Depends system property or {@link #setIndexingEnabled(boolean)}.
+ *
+ */
+ private static volatile boolean indexingEnabled = Boolean.valueOf(System.getProperty("org.netbeans.modules.groovy.editor.api.indexingEnabled", "true"));
+
+ /**
+ * Disables completely Groovy indexing. Temporary options only for 12.5 release, will be hopefully
+ * removed after Groovy performance improves. Currently used reflectively from java.lsp.server module only.
+ * DO NOT expose as an API.
+ * @param enabled
+ */
Review comment:
Will add, but it isn't a public/friend accssible class anyway.
##########
File path: groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/utils/GroovyUtils.java
##########
@@ -236,4 +236,25 @@ private static String stripPackageFromTypeParams(String params) {
}
return sb.toString();
}
+
+ /**
+ * True, if the indexing is enabled. Depends system property or {@link #setIndexingEnabled(boolean)}.
+ *
+ */
+ private static volatile boolean indexingEnabled = Boolean.valueOf(System.getProperty("org.netbeans.modules.groovy.editor.api.indexingEnabled", "true"));
Review comment:
I considered the 'solution' a hack, so I didn't plan to document it in arch document; otherwise I'd make a proper friend API call for it. After all, this hack should improve / change during 12.5 release - should we document it in the API/arch docs ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists