You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2016/09/20 13:05:48 UTC

[GitHub] incubator-carbondata pull request #179: [CARBONDATA-214]Remove binary file a...

GitHub user ravipesala opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/179

    [CARBONDATA-214]Remove binary file and generate the binary file on fly while running the test case

    Remove binary file and generate the binary file on fly while running the test case

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata remove-binary

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #179
    
----
commit 8b7b735a42093c928f746844351a930a60fa9087
Author: ravipesala <ra...@gmail.com>
Date:   2016-09-20T13:02:01Z

    Remove binary file generate the binary file on fly while running the test case.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #179: [CARBONDATA-214]Remove binary file a...

Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/179#discussion_r79872943
  
    --- Diff: processing/src/test/java/org/apache/carbondata/test/util/StoreCreator.java ---
    @@ -0,0 +1,565 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.carbondata.test.util;
    +
    +import java.io.BufferedReader;
    +import java.io.BufferedWriter;
    +import java.io.DataOutputStream;
    +import java.io.File;
    +import java.io.FileReader;
    +import java.io.IOException;
    +import java.io.OutputStreamWriter;
    +import java.nio.charset.Charset;
    +import java.text.SimpleDateFormat;
    +import java.util.ArrayList;
    +import java.util.Date;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Set;
    +import java.util.UUID;
    +
    +import org.apache.carbondata.core.cache.Cache;
    +import org.apache.carbondata.core.cache.CacheProvider;
    +import org.apache.carbondata.core.cache.CacheType;
    +import org.apache.carbondata.core.cache.dictionary.Dictionary;
    +import org.apache.carbondata.core.cache.dictionary.DictionaryColumnUniqueIdentifier;
    +import org.apache.carbondata.core.carbon.AbsoluteTableIdentifier;
    +import org.apache.carbondata.core.carbon.CarbonDataLoadSchema;
    +import org.apache.carbondata.core.carbon.CarbonTableIdentifier;
    +import org.apache.carbondata.core.carbon.ColumnIdentifier;
    +import org.apache.carbondata.core.carbon.metadata.CarbonMetadata;
    +import org.apache.carbondata.core.carbon.metadata.converter.SchemaConverter;
    +import org.apache.carbondata.core.carbon.metadata.converter.ThriftWrapperSchemaConverterImpl;
    +import org.apache.carbondata.core.carbon.metadata.datatype.DataType;
    +import org.apache.carbondata.core.carbon.metadata.encoder.Encoding;
    +import org.apache.carbondata.core.carbon.metadata.schema.SchemaEvolution;
    +import org.apache.carbondata.core.carbon.metadata.schema.SchemaEvolutionEntry;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.CarbonTable;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.TableInfo;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.TableSchema;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.column.CarbonColumn;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.column.CarbonDimension;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.column.CarbonMeasure;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.column.ColumnSchema;
    +import org.apache.carbondata.core.carbon.path.CarbonStorePath;
    +import org.apache.carbondata.core.carbon.path.CarbonTablePath;
    +import org.apache.carbondata.core.constants.CarbonCommonConstants;
    +import org.apache.carbondata.core.datastorage.store.impl.FileFactory;
    +import org.apache.carbondata.core.load.BlockDetails;
    +import org.apache.carbondata.core.load.LoadMetadataDetails;
    +import org.apache.carbondata.core.util.CarbonProperties;
    +import org.apache.carbondata.core.util.CarbonUtil;
    +import org.apache.carbondata.core.writer.CarbonDictionaryWriter;
    +import org.apache.carbondata.core.writer.CarbonDictionaryWriterImpl;
    +import org.apache.carbondata.core.writer.ThriftWriter;
    +import org.apache.carbondata.core.writer.sortindex.CarbonDictionarySortIndexWriter;
    +import org.apache.carbondata.core.writer.sortindex.CarbonDictionarySortIndexWriterImpl;
    +import org.apache.carbondata.core.writer.sortindex.CarbonDictionarySortInfo;
    +import org.apache.carbondata.core.writer.sortindex.CarbonDictionarySortInfoPreparator;
    +import org.apache.carbondata.lcm.fileoperations.AtomicFileOperations;
    +import org.apache.carbondata.lcm.fileoperations.AtomicFileOperationsImpl;
    +import org.apache.carbondata.lcm.fileoperations.FileWriteOperation;
    +import org.apache.carbondata.processing.api.dataloader.DataLoadModel;
    +import org.apache.carbondata.processing.api.dataloader.SchemaInfo;
    +import org.apache.carbondata.processing.csvload.DataGraphExecuter;
    +import org.apache.carbondata.processing.dataprocessor.DataProcessTaskStatus;
    +import org.apache.carbondata.processing.dataprocessor.IDataProcessStatus;
    +import org.apache.carbondata.processing.graphgenerator.GraphGenerator;
    +import org.apache.carbondata.processing.graphgenerator.GraphGeneratorException;
    +import org.apache.carbondata.processing.util.CarbonDataProcessorUtil;
    +
    +import com.google.gson.Gson;
    +
    +/**
    + * This class will create store file based on provided schema
    + *
    + * @author Administrator
    --- End diff --
    
    please remove "@author Administrator"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #179: [CARBONDATA-214]Remove binary file a...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/179


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #179: [CARBONDATA-214]Remove binary file a...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/179#discussion_r79873826
  
    --- Diff: processing/src/test/java/org/apache/carbondata/test/util/StoreCreator.java ---
    @@ -0,0 +1,565 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.carbondata.test.util;
    +
    +import java.io.BufferedReader;
    +import java.io.BufferedWriter;
    +import java.io.DataOutputStream;
    +import java.io.File;
    +import java.io.FileReader;
    +import java.io.IOException;
    +import java.io.OutputStreamWriter;
    +import java.nio.charset.Charset;
    +import java.text.SimpleDateFormat;
    +import java.util.ArrayList;
    +import java.util.Date;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Set;
    +import java.util.UUID;
    +
    +import org.apache.carbondata.core.cache.Cache;
    +import org.apache.carbondata.core.cache.CacheProvider;
    +import org.apache.carbondata.core.cache.CacheType;
    +import org.apache.carbondata.core.cache.dictionary.Dictionary;
    +import org.apache.carbondata.core.cache.dictionary.DictionaryColumnUniqueIdentifier;
    +import org.apache.carbondata.core.carbon.AbsoluteTableIdentifier;
    +import org.apache.carbondata.core.carbon.CarbonDataLoadSchema;
    +import org.apache.carbondata.core.carbon.CarbonTableIdentifier;
    +import org.apache.carbondata.core.carbon.ColumnIdentifier;
    +import org.apache.carbondata.core.carbon.metadata.CarbonMetadata;
    +import org.apache.carbondata.core.carbon.metadata.converter.SchemaConverter;
    +import org.apache.carbondata.core.carbon.metadata.converter.ThriftWrapperSchemaConverterImpl;
    +import org.apache.carbondata.core.carbon.metadata.datatype.DataType;
    +import org.apache.carbondata.core.carbon.metadata.encoder.Encoding;
    +import org.apache.carbondata.core.carbon.metadata.schema.SchemaEvolution;
    +import org.apache.carbondata.core.carbon.metadata.schema.SchemaEvolutionEntry;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.CarbonTable;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.TableInfo;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.TableSchema;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.column.CarbonColumn;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.column.CarbonDimension;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.column.CarbonMeasure;
    +import org.apache.carbondata.core.carbon.metadata.schema.table.column.ColumnSchema;
    +import org.apache.carbondata.core.carbon.path.CarbonStorePath;
    +import org.apache.carbondata.core.carbon.path.CarbonTablePath;
    +import org.apache.carbondata.core.constants.CarbonCommonConstants;
    +import org.apache.carbondata.core.datastorage.store.impl.FileFactory;
    +import org.apache.carbondata.core.load.BlockDetails;
    +import org.apache.carbondata.core.load.LoadMetadataDetails;
    +import org.apache.carbondata.core.util.CarbonProperties;
    +import org.apache.carbondata.core.util.CarbonUtil;
    +import org.apache.carbondata.core.writer.CarbonDictionaryWriter;
    +import org.apache.carbondata.core.writer.CarbonDictionaryWriterImpl;
    +import org.apache.carbondata.core.writer.ThriftWriter;
    +import org.apache.carbondata.core.writer.sortindex.CarbonDictionarySortIndexWriter;
    +import org.apache.carbondata.core.writer.sortindex.CarbonDictionarySortIndexWriterImpl;
    +import org.apache.carbondata.core.writer.sortindex.CarbonDictionarySortInfo;
    +import org.apache.carbondata.core.writer.sortindex.CarbonDictionarySortInfoPreparator;
    +import org.apache.carbondata.lcm.fileoperations.AtomicFileOperations;
    +import org.apache.carbondata.lcm.fileoperations.AtomicFileOperationsImpl;
    +import org.apache.carbondata.lcm.fileoperations.FileWriteOperation;
    +import org.apache.carbondata.processing.api.dataloader.DataLoadModel;
    +import org.apache.carbondata.processing.api.dataloader.SchemaInfo;
    +import org.apache.carbondata.processing.csvload.DataGraphExecuter;
    +import org.apache.carbondata.processing.dataprocessor.DataProcessTaskStatus;
    +import org.apache.carbondata.processing.dataprocessor.IDataProcessStatus;
    +import org.apache.carbondata.processing.graphgenerator.GraphGenerator;
    +import org.apache.carbondata.processing.graphgenerator.GraphGeneratorException;
    +import org.apache.carbondata.processing.util.CarbonDataProcessorUtil;
    +
    +import com.google.gson.Gson;
    +
    +/**
    + * This class will create store file based on provided schema
    + *
    + * @author Administrator
    --- End diff --
    
    Ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---