You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "cchung100m (via GitHub)" <gi...@apache.org> on 2023/06/03 03:50:56 UTC
[GitHub] [incubator-uniffle] cchung100m opened a new pull request, #924: [apache#343][Improvement] Shade Netty Native lib
cchung100m opened a new pull request, #924:
URL: https://github.com/apache/incubator-uniffle/pull/924
Hi @jerqi
Any comments and suggestions would be appreciated if you are available, thank you.
### What changes were proposed in this pull request?
Add the shade Netty Native lib into` pom.xml`
### Why are the changes needed?
Fix: #343
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
current UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] cchung100m commented on pull request #924: [#343] improvement(build): Shade Netty Native lib
Posted by "cchung100m (via GitHub)" <gi...@apache.org>.
cchung100m commented on PR #924:
URL: https://github.com/apache/incubator-uniffle/pull/924#issuecomment-1582839592
Hi @jerqi
It seems like there are some integration testing errors that occurred, any suggestions would be appreciated if you are available to help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #924: [#343]improvement(build): Shade Netty Native lib
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #924:
URL: https://github.com/apache/incubator-uniffle/pull/924#issuecomment-1574649018
We should only shade jars in the framework client like client-spark3, client-spark2, client-mr. You can modify https://github.com/apache/incubator-uniffle/blob/d09cdc22eb77306530c689ef273b51953e9095c2/client-spark/spark3/pom.xml#L96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #924: [#343] improvement(build): Shade Netty Native lib
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #924:
URL: https://github.com/apache/incubator-uniffle/pull/924#issuecomment-1575598828
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/924?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#924](https://app.codecov.io/gh/apache/incubator-uniffle/pull/924?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5f219f4) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/d09cdc22eb77306530c689ef273b51953e9095c2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d09cdc2) will **increase** coverage by `1.19%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #924 +/- ##
============================================
+ Coverage 55.53% 56.73% +1.19%
+ Complexity 2246 1978 -268
============================================
Files 341 291 -50
Lines 16626 12029 -4597
Branches 1327 1130 -197
============================================
- Hits 9234 6825 -2409
+ Misses 6863 4810 -2053
+ Partials 529 394 -135
```
[see 55 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/924/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] cchung100m commented on pull request #924: [#343] improvement(build): Shade Netty Native lib
Posted by "cchung100m (via GitHub)" <gi...@apache.org>.
cchung100m commented on PR #924:
URL: https://github.com/apache/incubator-uniffle/pull/924#issuecomment-1575569898
> We should only shade jars in the framework client like client-spark3, client-spark2, client-mr. You can modify
>
> https://github.com/apache/incubator-uniffle/blob/d09cdc22eb77306530c689ef273b51953e9095c2/client-spark/spark3/pom.xml#L96
Hi @jerqi
Thanks for the prompt reply. I'd like to confirm whether the proposed change is feasible or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #924: [#343] improvement(build): Shade Netty Native lib
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #924:
URL: https://github.com/apache/incubator-uniffle/pull/924#issuecomment-1575570997
> > We should only shade jars in the framework client like client-spark3, client-spark2, client-mr. You can modify
> > https://github.com/apache/incubator-uniffle/blob/d09cdc22eb77306530c689ef273b51953e9095c2/client-spark/spark3/pom.xml#L96
>
> Hi @jerqi
>
> Thanks for the prompt reply. I'd like to confirm whether the proposed change is feasible or not.
Yes, I think it is feasible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] cchung100m commented on a diff in pull request #924: [#343] improvement(build): Shade Netty Native lib
Posted by "cchung100m (via GitHub)" <gi...@apache.org>.
cchung100m commented on code in PR #924:
URL: https://github.com/apache/incubator-uniffle/pull/924#discussion_r1225036599
##########
server/pom.xml:
##########
@@ -203,6 +203,13 @@
<pattern>com.fasterxml.jackson.databind</pattern>
<shadedPattern>${rss.shade.packageName}.jackson.databind</shadedPattern>
</relocation>
+ <relocation>
Review Comment:
Hi @jerqi Thanks for the kind reminder and suggestions. I updated the part you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #924: [#343] improvement(build): Shade Netty Native lib
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #924:
URL: https://github.com/apache/incubator-uniffle/pull/924#discussion_r1223737697
##########
server/pom.xml:
##########
@@ -203,6 +203,13 @@
<pattern>com.fasterxml.jackson.databind</pattern>
<shadedPattern>${rss.shade.packageName}.jackson.databind</shadedPattern>
</relocation>
+ <relocation>
Review Comment:
Could you revert this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #924: [#343] improvement(build): Shade Netty Native lib
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #924:
URL: https://github.com/apache/incubator-uniffle/pull/924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org