You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/05/19 19:22:51 UTC

[GitHub] [couchdb-erlfdb] davisp commented on a change in pull request #8: Cancel fold range futures

davisp commented on a change in pull request #8:
URL: https://github.com/apache/couchdb-erlfdb/pull/8#discussion_r427544292



##########
File path: src/erlfdb.erl
##########
@@ -190,13 +191,20 @@ reset(?IS_TX = Tx) ->
     ok = erlfdb_nif:transaction_reset(Tx).
 
 
+cancel(?IS_FOLD_FUTURE = FoldInfo) ->

Review comment:
       Kinda weird that we only proxy through for one. I'd switch the other two to proxy as well for consistency.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org