You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "David Chen (JIRA)" <ji...@apache.org> on 2014/09/11 23:00:34 UTC

[jira] [Updated] (SAMZA-412) Use assertTrue, assertFalse, assertEquals, etc rather than assert

     [ https://issues.apache.org/jira/browse/SAMZA-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Chen updated SAMZA-412:
-----------------------------
    Description: 
I noticed that a number of tests use {{assert}} rather than JUnit's {{assertTrue}}, {{assertFalse}}, {{assertEquals}}, etc. methods. From looking at the [JUnit.Assert Javadoc|http://junit.sourceforge.net/javadoc/org/junit/Assert.html], it appears that we are currently just using the Scala {{assert}} rather than a JUnit method.

We should change all uses of {{assert}} to use one of the {{JUnit.Assert}} methods.

  was:
I noticed that a number of tests use {{assert}} rather than JUnit's {{assertTrue}}, {{assertFalse}}, {{assertEquals}}, etc. methods. From looking at the [JUnit.Assert Javadoc|http://junit.sourceforge.net/javadoc/org/junit/Assert.html], it appears that we are currently just using the Scala {{assert}} macro rather than a JUnit method.

We should change all uses of {{assert}} to use one of the {{JUnit.Assert}} methods.


> Use assertTrue, assertFalse, assertEquals, etc rather than assert
> -----------------------------------------------------------------
>
>                 Key: SAMZA-412
>                 URL: https://issues.apache.org/jira/browse/SAMZA-412
>             Project: Samza
>          Issue Type: Test
>            Reporter: David Chen
>            Assignee: David Chen
>
> I noticed that a number of tests use {{assert}} rather than JUnit's {{assertTrue}}, {{assertFalse}}, {{assertEquals}}, etc. methods. From looking at the [JUnit.Assert Javadoc|http://junit.sourceforge.net/javadoc/org/junit/Assert.html], it appears that we are currently just using the Scala {{assert}} rather than a JUnit method.
> We should change all uses of {{assert}} to use one of the {{JUnit.Assert}} methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)