svn commit: r691961 - /tuscany/java/sca/modules/binding-sca-jms/src/main/java/org/apache/tuscany/sca/binding/sca/jms/JMSSCABindingProviderFactory.java

[an...@apache.org]

Author: antelder
Date: Thu Sep  4 03:40:29 2008
New Revision: 691961

URL: http://svn.apache.org/viewvc?rev=691961&view=rev
Log:
Correct JMS binding.sca destination create options

Modified:
    tuscany/java/sca/modules/binding-sca-jms/src/main/java/org/apache/tuscany/sca/binding/sca/jms/JMSSCABindingProviderFactory.java

Modified: tuscany/java/sca/modules/binding-sca-jms/src/main/java/org/apache/tuscany/sca/binding/sca/jms/JMSSCABindingProviderFactory.java
URL: http://svn.apache.org/viewvc/tuscany/java/sca/modules/binding-sca-jms/src/main/java/org/apache/tuscany/sca/binding/sca/jms/JMSSCABindingProviderFactory.java?rev=691961&r1=691960&r2=691961&view=diff
==============================================================================
--- tuscany/java/sca/modules/binding-sca-jms/src/main/java/org/apache/tuscany/sca/binding/sca/jms/JMSSCABindingProviderFactory.java (original)
+++ tuscany/java/sca/modules/binding-sca-jms/src/main/java/org/apache/tuscany/sca/binding/sca/jms/JMSSCABindingProviderFactory.java Thu Sep  4 03:40:29 2008
@@ -51,6 +51,13 @@
                                                                    RuntimeComponentReference reference,
                                                                    DistributedSCABinding binding) {
         JMSBinding jmsBinding = createBinding(binding);
+
+        // FIXME: CREATE_NEVER doesn't work as the dynamically created JNDI destinations 
+        // aren't replicated around the broker cluster. Maybe it needs an AMQ specific
+        // impl of the Tuscany JMSResourceFactory which uses use physical destinations 
+        // instead of JNDI
+        //jmsBinding.setDestinationCreate(JMSBindingConstants.CREATE_NEVER);
+
         return new JMSBindingReferenceBindingProvider(component, reference, jmsBinding);
     }
 
@@ -58,6 +65,7 @@
                                                                RuntimeComponentService service,
                                                                DistributedSCABinding binding) {
         JMSBinding jmsBinding = createBinding(binding);
+        jmsBinding.setDestinationCreate(JMSBindingConstants.CREATE_ALWAYS);
         return new JMSBindingServiceBindingProvider(component, service, binding.getSCABinding(), jmsBinding, workScheduler);
     }