You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/09/13 14:54:01 UTC

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10248: IGNITE-17668 Fix removing archive WAL segments for in-memory CDC mode

NSAmelchev commented on code in PR #10248:
URL: https://github.com/apache/ignite/pull/10248#discussion_r969735363


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/IgniteCacheDatabaseSharedManager.java:
##########
@@ -1158,15 +1158,21 @@ public void startMemoryRestore(GridKernalContext kctx, TimeBag startTimer) throw
 
         WALIterator iter = cctx.wal(true).replay(null, (type, ptr) -> true);
 
-        while (iter.hasNext())
-            iter.next();
+        try {

Review Comment:
   why not try-with-resources?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org