You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Daniel Pitts (JIRA)" <ji...@apache.org> on 2011/09/19 02:10:08 UTC

[jira] [Created] (OGNL-22) Change the generics signature of ClassCache and ClassCacheImpl.

Change the generics signature of ClassCache and ClassCacheImpl.
---------------------------------------------------------------

                 Key: OGNL-22
                 URL: https://issues.apache.org/jira/browse/OGNL-22
             Project: OGNL
          Issue Type: Improvement
            Reporter: Daniel Pitts


Right now, ClassCache and ClassCacheImpl use some generics, but they do casting at the method level, which leads to possible ClassCastException, and doesn't quite support safe static typing.  

I'll be glad to provide a patch when I have some time.  I'd like to have OGNL-21 resolved first, as it reduces the amount of code I'd have to touch to implement this change.

The proposed signatures would be interface ClassCache<V> and class ClassCacheImpl<V> implements ClassCache<V>

Changing the get/put methods to take and return "V" type objects.

Alternative to this is to replace all of them with a "ConcurrentMap<Class<?>, V>".


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (OGNL-22) Change the generics signature of ClassCache and ClassCacheImpl.

Posted by "Maurizio Cucchiara (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OGNL-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maurizio Cucchiara resolved OGNL-22.
------------------------------------

    Resolution: Fixed
      Assignee: Maurizio Cucchiara

Fixed with OGNL-20 
                
> Change the generics signature of ClassCache and ClassCacheImpl.
> ---------------------------------------------------------------
>
>                 Key: OGNL-22
>                 URL: https://issues.apache.org/jira/browse/OGNL-22
>             Project: OGNL
>          Issue Type: Sub-task
>            Reporter: Daniel Pitts
>            Assignee: Maurizio Cucchiara
>
> Right now, ClassCache and ClassCacheImpl use some generics, but they do casting at the method level, which leads to possible ClassCastException, and doesn't quite support safe static typing.  
> I'll be glad to provide a patch when I have some time.  I'd like to have OGNL-21 resolved first, as it reduces the amount of code I'd have to touch to implement this change.
> The proposed signatures would be interface ClassCache<V> and class ClassCacheImpl<V> implements ClassCache<V>
> Changing the get/put methods to take and return "V" type objects.
> Alternative to this is to replace all of them with a "ConcurrentMap<Class<?>, V>".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OGNL-22) Change the generics signature of ClassCache and ClassCacheImpl.

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OGNL-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133778#comment-13133778 ] 

Hudson commented on OGNL-22:
----------------------------

Integrated in ognl #147 (See [https://builds.apache.org/job/ognl/147/])
    Added OGNL-22 in the issue list

mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1188002
Files : 
* /commons/proper/ognl/trunk/src/changes/changes.xml

                
> Change the generics signature of ClassCache and ClassCacheImpl.
> ---------------------------------------------------------------
>
>                 Key: OGNL-22
>                 URL: https://issues.apache.org/jira/browse/OGNL-22
>             Project: OGNL
>          Issue Type: Sub-task
>            Reporter: Daniel Pitts
>            Assignee: Maurizio Cucchiara
>
> Right now, ClassCache and ClassCacheImpl use some generics, but they do casting at the method level, which leads to possible ClassCastException, and doesn't quite support safe static typing.  
> I'll be glad to provide a patch when I have some time.  I'd like to have OGNL-21 resolved first, as it reduces the amount of code I'd have to touch to implement this change.
> The proposed signatures would be interface ClassCache<V> and class ClassCacheImpl<V> implements ClassCache<V>
> Changing the get/put methods to take and return "V" type objects.
> Alternative to this is to replace all of them with a "ConcurrentMap<Class<?>, V>".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OGNL-22) Change the generics signature of ClassCache and ClassCacheImpl.

Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OGNL-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107679#comment-13107679 ] 

Simone Tripodi commented on OGNL-22:
------------------------------------

Definitively, OGNL-20 must be resolved first

> Change the generics signature of ClassCache and ClassCacheImpl.
> ---------------------------------------------------------------
>
>                 Key: OGNL-22
>                 URL: https://issues.apache.org/jira/browse/OGNL-22
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Daniel Pitts
>
> Right now, ClassCache and ClassCacheImpl use some generics, but they do casting at the method level, which leads to possible ClassCastException, and doesn't quite support safe static typing.  
> I'll be glad to provide a patch when I have some time.  I'd like to have OGNL-21 resolved first, as it reduces the amount of code I'd have to touch to implement this change.
> The proposed signatures would be interface ClassCache<V> and class ClassCacheImpl<V> implements ClassCache<V>
> Changing the get/put methods to take and return "V" type objects.
> Alternative to this is to replace all of them with a "ConcurrentMap<Class<?>, V>".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OGNL-22) Change the generics signature of ClassCache and ClassCacheImpl.

Posted by "Daniel Pitts (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OGNL-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107565#comment-13107565 ] 

Daniel Pitts commented on OGNL-22:
----------------------------------

By "Alternative to this" I mean implementing OGNL-20 for these caches. 

> Change the generics signature of ClassCache and ClassCacheImpl.
> ---------------------------------------------------------------
>
>                 Key: OGNL-22
>                 URL: https://issues.apache.org/jira/browse/OGNL-22
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Daniel Pitts
>
> Right now, ClassCache and ClassCacheImpl use some generics, but they do casting at the method level, which leads to possible ClassCastException, and doesn't quite support safe static typing.  
> I'll be glad to provide a patch when I have some time.  I'd like to have OGNL-21 resolved first, as it reduces the amount of code I'd have to touch to implement this change.
> The proposed signatures would be interface ClassCache<V> and class ClassCacheImpl<V> implements ClassCache<V>
> Changing the get/put methods to take and return "V" type objects.
> Alternative to this is to replace all of them with a "ConcurrentMap<Class<?>, V>".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (OGNL-22) Change the generics signature of ClassCache and ClassCacheImpl.

Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OGNL-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi updated OGNL-22:
-------------------------------

    Issue Type: Sub-task  (was: Improvement)
        Parent: OGNL-20

> Change the generics signature of ClassCache and ClassCacheImpl.
> ---------------------------------------------------------------
>
>                 Key: OGNL-22
>                 URL: https://issues.apache.org/jira/browse/OGNL-22
>             Project: OGNL
>          Issue Type: Sub-task
>            Reporter: Daniel Pitts
>
> Right now, ClassCache and ClassCacheImpl use some generics, but they do casting at the method level, which leads to possible ClassCastException, and doesn't quite support safe static typing.  
> I'll be glad to provide a patch when I have some time.  I'd like to have OGNL-21 resolved first, as it reduces the amount of code I'd have to touch to implement this change.
> The proposed signatures would be interface ClassCache<V> and class ClassCacheImpl<V> implements ClassCache<V>
> Changing the get/put methods to take and return "V" type objects.
> Alternative to this is to replace all of them with a "ConcurrentMap<Class<?>, V>".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira