[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #173: [FLINK-27310] Fix FlinkOperatorITCase

[GitBox <gi...@apache.org>]

wangyang0918 commented on code in PR #173:
URL: https://github.com/apache/flink-kubernetes-operator/pull/173#discussion_r853696615


##########
flink-kubernetes-operator/src/test/resources/log4j2-test.properties:
##########
@@ -34,7 +34,7 @@
 # limitations under the License.
 ################################################################################
 
-rootLogger.level = OFF
+rootLogger.level = INFO

Review Comment:
   Using `INFO` log level makes debugging failed tests easier. Hope it does not have other side effects.



##########
.github/workflows/ci.yml:
##########
@@ -73,7 +73,7 @@ jobs:
       - name: Tests in flink-kubernetes-operator
         run: |
           cd flink-kubernetes-operator
-          mvn integration-test -Dit.skip=false
+          mvn verify -Dit.skip=false

Review Comment:
   I am afraid the `org.apache.flink.kubernetes.operator.FlinkOperatorITCase` is not triggered by using `mvn verify`. Could you please confirm this?



##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/FlinkOperatorITCase.java:
##########
@@ -114,6 +114,7 @@ private static FlinkDeployment buildSessionCluster() {
         resource.setCpu(1);
         JobManagerSpec jm = new JobManagerSpec();
         jm.setResource(resource);
+        jm.setReplicas(1);

Review Comment:
   Why we have to set the replicas explicitly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org