[GitHub] [hive] maheshk114 commented on a change in pull request #2944: HIVE-25637: Hive on Tez: inserting data failing into the non native hive external table managed by kafka storage handler

[GitBox <gi...@apache.org>]

maheshk114 commented on a change in pull request #2944:
URL: https://github.com/apache/hive/pull/2944#discussion_r783073682



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java
##########
@@ -311,10 +325,18 @@ private void getKafkaCredentials(MapWork work, DAG dag, JobConf conf) {
         break;
       }
     }
+
+    for (TableDesc tableDesc : fileSinkTableDescs) {
+      kafkaBrokers = (String) tableDesc.getProperties().get("kafka.bootstrap.servers"); //FIXME: KafkaTableProperties
+      if (kafkaBrokers != null && !kafkaBrokers.isEmpty()) {

Review comment:
       The common code can be reused instead of another copy




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org