You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/28 20:53:22 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #4007: Minor: Do what clippy says and clean up some code
alamb opened a new pull request, #4007:
URL: https://github.com/apache/arrow-datafusion/pull/4007
# Which issue does this PR close?
N/A
# Rationale for this change
clippy says it is infallible, which it is
So make it so and remove some `?`
# What changes are included in this PR?
Fix a clippy lint
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #4007: Minor: Do what clippy says and clean up some code
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #4007:
URL: https://github.com/apache/arrow-datafusion/pull/4007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4007: Minor: Do what clippy says and clean up some code
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4007:
URL: https://github.com/apache/arrow-datafusion/pull/4007#issuecomment-1296228073
> I can't find this ability of clippy in doc, Can I ask how to use it?
I am not sure what you mean
In this case I found that someone had left a "#allow" command in the code (which ignores something clippy would normally flag a a warning). I removed the "allow" and then updated the code so clippy passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #4007: Minor: Do what clippy says and clean up some code
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #4007:
URL: https://github.com/apache/arrow-datafusion/pull/4007#issuecomment-1296232055
> In this case I found that someone had left a "#allow" command in the code (which ignores something clippy would normally flag a a warning). I removed the "allow" and then updated the code so clippy passed.
😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #4007: Minor: Do what clippy says and clean up some code
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #4007:
URL: https://github.com/apache/arrow-datafusion/pull/4007#issuecomment-1295832547
I can't find this ability of `clippy` in doc, Can I ask how to use it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4007: Minor: Do what clippy says and clean up some code
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4007:
URL: https://github.com/apache/arrow-datafusion/pull/4007#issuecomment-1296300613
Benchmark runs are scheduled for baseline = d6f0b1261159f6f97cb14357489d9081e8bbd7ab and contender = f4d70ac3e1c4298f9ea5ebb12855a95d60d2b737. f4d70ac3e1c4298f9ea5ebb12855a95d60d2b737 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a1213c1ccd324da49de1c2c507eb5c80...56b024be114d428db9d1693ffe57468e/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2a72880027034df8848f0d8757670fb8...37705717f2634c15978b36a14e6c3cde/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2db18988522e4abebe11c5c4d4a25729...c7c8b49350ef4b0daf9813a90f00b5a9/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b78dbe65e69043a3b703fd5e258f96db...3f4b98ac0e4047f1a34089380c3dd656/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org