You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/17 07:01:09 UTC
[GitHub] [superset] PowerPlop opened a new issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
PowerPlop opened a new issue #16724:
URL: https://github.com/apache/superset/issues/16724
A clear and concise description of what the bug is.
### Expected results
When selection the option 'Filter is hierarchical', you can choose which filter is the parent filter.
### Actual results
When opening the dropdown (which shows max 8 entries) and scrolling to the next 8 entries, the dropdown is automatically closed you cannot select a field.
#### Screenshots
#### How to reproduce the bug
1. Go to native filters settings
2. Click on hieraichical filter
3. Scroll down to next entries
4. dropdown closes
### Environment
- superset version: v1.3.1
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version of superset.
- [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] PowerPlop commented on issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
Posted by GitBox <gi...@apache.org>.
PowerPlop commented on issue #16724:
URL: https://github.com/apache/superset/issues/16724#issuecomment-923978089
@michael-s-molina Thanks for the effort on your side!!
Currently we still use the combination of native-filters and filter boxes as we feel that the native-filter is less suitable when you want to target 1 graph on the dashboard. While the highlighting of the chart tries to solve this, we prefer an additional filter box.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #16724:
URL: https://github.com/apache/superset/issues/16724#issuecomment-921985296
@PowerPlop Can you confirm the browser version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16724:
URL: https://github.com/apache/superset/issues/16724#issuecomment-921993439
@PowerPlop can you also confirm this is reproducible in latest master? it might have been fixed
also, do you see this behavior in other select dropdown in native filter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #16724:
URL: https://github.com/apache/superset/issues/16724#issuecomment-922921007
@PowerPlop Thanks for sharing the browser information. We tested here with Chrome, Firefox, and Safari and we're still not able to reproduce the problem. I noticed though that the design of the screen is different, particularly the button colors and the scroll bar of the modal which leads me to think you overrode some CSS props. This can or cannot be related to the problem. Can you share your CSS overrides?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina closed issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
Posted by GitBox <gi...@apache.org>.
michael-s-molina closed issue #16724:
URL: https://github.com/apache/superset/issues/16724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #16724:
URL: https://github.com/apache/superset/issues/16724#issuecomment-923080886
so far we've spent 2 hours reproducing this issue but no luck yet, we will give another try today, if still can't, let's table it for now.
cc @jinghua-qa
https://user-images.githubusercontent.com/67837651/134045320-79afb8b5-4653-486d-b332-f2f8898e5de5.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #16724:
URL: https://github.com/apache/superset/issues/16724#issuecomment-931552741
Closed by #16702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on issue #16724:
URL: https://github.com/apache/superset/issues/16724#issuecomment-922921007
@PowerPlop Thanks for sharing the browser information. We tested here with Chrome, Firefox, and Safari and we're still not able to reproduce the problem. I noticed though that the design of the screen is different, particularly the button colors and the scroll bar of the modal which leads me to think you overrode some CSS props. This may or may not be related to the problem. Can you share your CSS overrides?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16724:
URL: https://github.com/apache/superset/issues/16724#issuecomment-923080886
so far we've spent 2 hours reproducing this issue but no luck yet, we will give another try today, if still can't, let's table it for now.
cc @jinghua-qa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on issue #16724:
URL: https://github.com/apache/superset/issues/16724#issuecomment-923961303
@PowerPlop We were able to reproduce the problem when we have a filter box inside the dashboard. The fix in #16702 will be included in 1.3.1 that is going to be put up for voting shortly. Thank you so much for reporting the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] PowerPlop commented on issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
Posted by GitBox <gi...@apache.org>.
PowerPlop commented on issue #16724:
URL: https://github.com/apache/superset/issues/16724#issuecomment-923115694
@junlincc do you have a public test instance of superset where I can try to replicate? That way we can rule out any local settings that might cause this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] PowerPlop commented on issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
Posted by GitBox <gi...@apache.org>.
PowerPlop commented on issue #16724:
URL: https://github.com/apache/superset/issues/16724#issuecomment-922671996
@michael-s-molina Chrome Version 93.0.4577.82 ; same in firefox
@junlincc I can replicate it in a preset workspace (which uses latest master I assume?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on issue #16724:
URL: https://github.com/apache/superset/issues/16724#issuecomment-923961303
@PowerPlop We were able to reproduce the problem when we have a filter box inside the dashboard. The fix in #16702 will be included in 1.3.2 that is going to be put up for voting shortly. Thank you so much for reporting the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on issue #16724:
URL: https://github.com/apache/superset/issues/16724#issuecomment-931552741
Fixed by #16702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] PowerPlop commented on issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
Posted by GitBox <gi...@apache.org>.
PowerPlop commented on issue #16724:
URL: https://github.com/apache/superset/issues/16724#issuecomment-922972141
@michael-s-molina we do have indeed some superset front end overwrites + custom CSS, but I do have the same issue on my preset instance.
You can find a new gif below. In the second part of the GIF I try to navigate with the arrows but even there the popup closes.
The issue also occurs in microsoft edge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] PowerPlop commented on issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
Posted by GitBox <gi...@apache.org>.
PowerPlop commented on issue #16724:
URL: https://github.com/apache/superset/issues/16724#issuecomment-924647854
@junlincc
Lets say you have a dashboard with 5 charts (and more tabs with more charts).
3 charts are generic total counts and should not be filtered on anything. Below you have more detailed charts that can be filtered on time or one instance (e.g. a specific client).
When all filters are located in the native-filter side bar, it is not clear which filters will apply to which charts.
By using a filter box and placing them next to the impacted charts (+ a descriptive title), the user understands that the top 3 charts will not be filtered, and the filter has to be used for the more specific charts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16724:
URL: https://github.com/apache/superset/issues/16724#issuecomment-924577430
> we feel that the native-filter is less suitable when you want to target 1 graph on the dashboard.
Hi @PowerPlop, Filterbox will co-exist with native filter until the end of the year, we wanna make sure native filter reaches full feature parity and is an overall better solution for dashboard filtering before removing the filterbox. Can you elaborate on why native-filter is not ideal for targeting 1 chart on the dashboard. And what's the reason behind adding only 1 chart to the dashboard?
@michael-s-molina since this s an edge case and we are deprecating filterbox soon. i suggest not to invest more time making Filterbox and Nativefilter compatible. 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #16724: (native-filters) Filter is hierarchical dropdown does not list all options
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #16724:
URL: https://github.com/apache/superset/issues/16724#issuecomment-923961303
@PowerPlop We were able to reproduce the problem when we have a filter box inside the dashboard. The fix in #16702 will be included in 1.3.1rc2 that is going to be put up for voting shortly. Thank you so much for reporting the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org