You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Dries Schulten (JIRA)" <ji...@apache.org> on 2011/09/21 09:10:09 UTC
[jira] [Created] (WICKET-4071) AjaxIndicatorAppender removes itself
immediately when added via ajax
AjaxIndicatorAppender removes itself immediately when added via ajax
--------------------------------------------------------------------
Key: WICKET-4071
URL: https://issues.apache.org/jira/browse/WICKET-4071
Project: Wicket
Issue Type: Bug
Components: wicket-extensions
Affects Versions: 1.5.0
Reporter: Dries Schulten
Priority: Minor
When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4071) AjaxIndicatorAppender removes
itself immediately when added via ajax
Posted by "Andrea Del Bene (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146538#comment-13146538 ]
Andrea Del Bene commented on WICKET-4071:
-----------------------------------------
It seems that in the last source's version my proposed patch has been reverted to the previous code.
Anyway, if you look at class AbstractDefaultAjaxBehavior (method generateCallbackScript) you can see that this class already uses a decorator to generate JavaScript code to hide indicator after ajax request has completed.
So we shouldn't care about hide/remove indicator inside AjaxIndicatorAppender. See proposed patch.
PS: if you run Ivan's project with this patch , you may occasionally not see the indicator when you change <select> value. That's because ajax response it's too fast and animated gif is showed and suddenly hidden.
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.5.3
>
> Attachments: WICKET-4071.patch, hideIndicator.patch, myproject.rar, myproject.zip
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-4071) AjaxIndicatorAppender removes
itself immediately when added via ajax
Posted by "Martin Grigorov (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-4071:
---------------------------------------
Assignee: Martin Grigorov (was: Igor Vaynberg)
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.5.3
>
> Attachments: WICKET-4071.patch, cancelRenderHead.patch, hideIndicator.patch, myproject.rar, myproject.zip
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4071) AjaxIndicatorAppender removes
itself immediately when added via ajax
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-4071.
-----------------------------------
Resolution: Cannot Reproduce
Assignee: Igor Vaynberg
i could not reproduce this with trunk, attaching a quickstart that shows its working...
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Assignee: Igor Vaynberg
> Priority: Minor
> Attachments: WICKET-4071.patch, myproject.rar
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4071) AjaxIndicatorAppender removes itself
immediately when added via ajax
Posted by "Igor Vaynberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-4071:
----------------------------------
Fix Version/s: 1.5.3
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.5.3
>
> Attachments: WICKET-4071.patch, hideIndicator.patch, myproject.rar, myproject.zip
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (WICKET-4071) AjaxIndicatorAppender removes
itself immediately when added via ajax
Posted by "Igor Vaynberg (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reopened WICKET-4071:
-----------------------------------
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.5.3
>
> Attachments: WICKET-4071.patch, hideIndicator.patch, myproject.rar, myproject.zip
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4071) AjaxIndicatorAppender removes itself
immediately when added via ajax
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-4071:
----------------------------------
Attachment: myproject.rar
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Assignee: Igor Vaynberg
> Priority: Minor
> Attachments: WICKET-4071.patch, myproject.rar
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4071) AjaxIndicatorAppender removes itself
immediately when added via ajax
Posted by "Andrea Del Bene (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrea Del Bene updated WICKET-4071:
------------------------------------
Attachment: hideIndicator.patch
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Priority: Minor
> Attachments: WICKET-4071.patch, hideIndicator.patch, myproject.rar, myproject.zip
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4071) AjaxIndicatorAppender removes itself
immediately when added via ajax
Posted by "SoulSpirit (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
SoulSpirit updated WICKET-4071:
-------------------------------
Attachment: myproject.zip
The 2nd time you change the selection in the dropdown, no indicator appears.
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Assignee: Igor Vaynberg
> Priority: Minor
> Attachments: WICKET-4071.patch, myproject.rar, myproject.zip
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (WICKET-4071) AjaxIndicatorAppender
removes itself immediately when added via ajax
Posted by "Ivan Vasilev (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145827#comment-13145827 ]
Ivan Vasilev edited comment on WICKET-4071 at 11/7/11 9:28 PM:
---------------------------------------------------------------
The issue is still reproducible with myproject.zip - https://issues.apache.org/jira/secure/attachment/12501060/myproject.zip.
was (Author: hok):
The issue is still reproducible with myproject.zip - https://issues.apache.org/jira/secure/attachment/12501060/myproject.zip (and in my source also).
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.5.3
>
> Attachments: WICKET-4071.patch, hideIndicator.patch, myproject.rar, myproject.zip
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4071) AjaxIndicatorAppender removes
itself immediately when added via ajax
Posted by "Andrea Del Bene (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137126#comment-13137126 ]
Andrea Del Bene commented on WICKET-4071:
-----------------------------------------
Why not simply hide indicator span instead of removing it. See patch. It works well, but I didn't find a good solution to prevent method afterRender writes span in response each time component is rendered.
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Priority: Minor
> Attachments: WICKET-4071.patch, hideIndicator.patch, myproject.rar, myproject.zip
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4071) AjaxIndicatorAppender removes
itself immediately when added via ajax
Posted by "Martin Grigorov (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4071.
-------------------------------------
Resolution: Fixed
Replaced target.appendJS() with .prependJS() (related to the change with 'priority-evaluate' done by Igor in another ticket).
This way both quickstarts attached to this ticket work.
@Andrea: your solution worked only for myproject.zip (the one with the drop-down).
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.5.3
>
> Attachments: WICKET-4071.patch, cancelRenderHead.patch, hideIndicator.patch, myproject.rar, myproject.zip
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4071) AjaxIndicatorAppender removes
itself immediately when added via ajax
Posted by "Dries Schulten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109500#comment-13109500 ]
Dries Schulten commented on WICKET-4071:
----------------------------------------
The patch doesn't fix it, the javascript stil runs after component replace has finished, thus deleting the newly added indicator... So I changed it to prependJavaScript, but the scripts that are added via prepend don't get renderd.
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Priority: Minor
> Attachments: WICKET-4071.patch
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4071) AjaxIndicatorAppender removes
itself immediately when added via ajax
Posted by "Igor Vaynberg (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-4071.
-----------------------------------
Resolution: Fixed
Assignee: Igor Vaynberg
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Assignee: Igor Vaynberg
> Priority: Minor
> Attachments: WICKET-4071.patch, hideIndicator.patch, myproject.rar, myproject.zip
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4071) AjaxIndicatorAppender removes
itself immediately when added via ajax
Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136880#comment-13136880 ]
Martin Grigorov commented on WICKET-4071:
-----------------------------------------
Please update the attached quickstart application so that it fails.
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Assignee: Igor Vaynberg
> Priority: Minor
> Attachments: WICKET-4071.patch, myproject.rar
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4071) AjaxIndicatorAppender removes itself
immediately when added via ajax
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4071:
------------------------------------
Attachment: WICKET-4071.patch
Can you try this patch ?
Or provide a quickstart to test it myself.
Thanks!
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Priority: Minor
> Attachments: WICKET-4071.patch
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4071) AjaxIndicatorAppender removes itself
immediately when added via ajax
Posted by "Andrea Del Bene (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrea Del Bene updated WICKET-4071:
------------------------------------
Attachment: cancelRenderHead.patch
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.5.3
>
> Attachments: WICKET-4071.patch, cancelRenderHead.patch, hideIndicator.patch, myproject.rar, myproject.zip
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (WICKET-4071) AjaxIndicatorAppender removes
itself immediately when added via ajax
Posted by "Martin Grigorov (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reopened WICKET-4071:
-------------------------------------
Assignee: (was: Igor Vaynberg)
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Priority: Minor
> Attachments: WICKET-4071.patch, myproject.rar, myproject.zip
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4071) AjaxIndicatorAppender removes
itself immediately when added via ajax
Posted by "SoulSpirit (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136876#comment-13136876 ]
SoulSpirit commented on WICKET-4071:
------------------------------------
I'm encountering the same issue on Wicket 1.5.1, and the patch won't work.
The problem arises only when I add the container of the "indicated" component to the AjaxRequestTarget. Something like:
MarkupContainer container = new WebMarkupContainer( "container" );
FormComponent myIndicatingDropDown = new MyIndicatingDropDown( "dropdown" );
myIndicatingDropDown.add( new OnChangeAjaxBehavior() {
protected void onUpdate(AjaxRequestTarget target) {
target.add(container);
}
});
container.add( myIndicatingDropDown );
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Assignee: Igor Vaynberg
> Priority: Minor
> Attachments: WICKET-4071.patch, myproject.rar
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4071) AjaxIndicatorAppender removes
itself immediately when added via ajax
Posted by "Ivan Vasilev (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145827#comment-13145827 ]
Ivan Vasilev commented on WICKET-4071:
--------------------------------------
The issue is still reproducible with myproject.zip - https://issues.apache.org/jira/secure/attachment/12501060/myproject.zip (and in my source also).
> AjaxIndicatorAppender removes itself immediately when added via ajax
> --------------------------------------------------------------------
>
> Key: WICKET-4071
> URL: https://issues.apache.org/jira/browse/WICKET-4071
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0
> Reporter: Dries Schulten
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.5.3
>
> Attachments: WICKET-4071.patch, hideIndicator.patch, myproject.rar, myproject.zip
>
>
> When addding/replacing IndicatingAjaxLink's using ajax in Wicket 1.5.0 it's indicator markup is directly removed when parsing the ajax response. The AjaxIndicatorAppender renders a bit of javascript to the response (when it is an ajax request) to remove previous indicators from the dom (see issue WICKET-722) but in 1.5.0 the execution order of the javascript is different, causing the indicator markup to be added first and the javascript to remove *previous* versions of the indicator to be run next and thus removing the newly added indicator.
> De ajax debug windows shows that the component is replaced first and then the javascript is run. In 1.4.18 ajax logging shows the javascript run first and then the component gets replaced, resulting in correct behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira