[GitHub] [airflow] potiuk commented on pull request #23274: Remove custom signal handling in Triggerer

[GitBox <gi...@apache.org>]

potiuk commented on PR #23274:
URL: https://github.com/apache/airflow/pull/23274#issuecomment-1110302515

   CC: @andrewgodwin  @ashb  @dstandish  -> I was able to reproduce the Ctrl-C problem and it's gone after I removed the custom signal handling in Triggerer, so it looks like the hypothesis of the async.io bug from  https://bugs.python.org/issue39622 https://github.com/python/cpython/issues/83803 seems even more plausible.
   
   Pls. take a look and see if my Hypothesis from https://github.com/apache/airflow/pull/23271#issuecomment-1110260794 looks sound and maybe we can just fix it permanently also for production.
   
   I believe our custom signal handling of SIGINT and SIGTERM in Triggerer (which then would simply run sys.exit(0) ) is not really needed (default handling of both signals terminates the process eventually). I left SIGQUIT handling though for diagnostics (And QUIT is rarely used anyway for anything else).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org