You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2023/01/18 13:51:56 UTC
[GitHub] [mynewt-nimble] IshaESP opened a new pull request, #1428: Fixed a check in ble_att_clt_tx_prep_write() api
IshaESP opened a new pull request, #1428:
URL: https://github.com/apache/mynewt-nimble/pull/1428
If application is going to send data more than MTU size using ble_gattc_write_long(), after sending first batch of data of MTU size the offset gets incremented by (MTU - BLE_ATT_PREP_WRITE_CMD_BASE_SZ). This check will always fail in that case, as offset will be equal to (MTU - BLE_ATT_PREP_WRITE_CMD_BASE_SZ), and (offset + OS_MBUF_PKTLEN(txom)) will always be greater than BLE_ATT_ATTR_MAX_LEN. Thus failing to send the whole data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1428: Fixed a check in ble_att_clt_tx_prep_write() api
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1428:
URL: https://github.com/apache/mynewt-nimble/pull/1428#issuecomment-1387374434
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] IshaESP commented on pull request #1428: Fixed a check in ble_att_clt_tx_prep_write() api
Posted by "IshaESP (via GitHub)" <gi...@apache.org>.
IshaESP commented on PR #1428:
URL: https://github.com/apache/mynewt-nimble/pull/1428#issuecomment-1399841958
Hi @sjanc , can you please take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] codecoup-tester commented on pull request #1428: Fixed a check in ble_att_clt_tx_prep_write() api
Posted by "codecoup-tester (via GitHub)" <gi...@apache.org>.
codecoup-tester commented on PR #1428:
URL: https://github.com/apache/mynewt-nimble/pull/1428#issuecomment-1411742634
AutoPTS Bot results:
No failed test found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #1428: Fixed a check in ble_att_clt_tx_prep_write() api
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on PR #1428:
URL: https://github.com/apache/mynewt-nimble/pull/1428#issuecomment-1412063099
OK, so I'm not sure about this patch... spec clearly states that maximum attribute value shall be 512 and that data interpretation is responsibility of the higher layer. And offset is used for reading long attribute value but long here doesn't mean bigger than 512, but bigger than (ATT_MTU -1)..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] IshaESP commented on pull request #1428: Fixed a check in ble_att_clt_tx_prep_write() api
Posted by GitBox <gi...@apache.org>.
IshaESP commented on PR #1428:
URL: https://github.com/apache/mynewt-nimble/pull/1428#issuecomment-1387115322
Hi @sjanc ,
Can you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] codecoup-tester commented on pull request #1428: Fixed a check in ble_att_clt_tx_prep_write() api
Posted by "codecoup-tester (via GitHub)" <gi...@apache.org>.
codecoup-tester commented on PR #1428:
URL: https://github.com/apache/mynewt-nimble/pull/1428#issuecomment-1411727495
Scheduled PR #https://github.com/apache/mynewt-nimble/pull/1428#issuecomment-1410996839 after 10:25:44.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1428: Fixed a check in ble_att_clt_tx_prep_write() api
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1428:
URL: https://github.com/apache/mynewt-nimble/pull/1428#issuecomment-1396493840
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #1428: Fixed a check in ble_att_clt_tx_prep_write() api
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on PR #1428:
URL: https://github.com/apache/mynewt-nimble/pull/1428#issuecomment-1410996839
#AutoPTS run mynewt GATT/CL/GAW
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org