You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mehul Parikh <xs...@gmail.com> on 2023/04/11 12:39:01 UTC
Re: Review Request 74365: RANGER-4152: Create common module for metrics and add metrics in Admin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74365/#review225362
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On April 6, 2023, 2:51 p.m., Kishor Gollapalliwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74365/
> -----------------------------------------------------------
> 
> (Updated April 6, 2023, 2:51 p.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4152
>     https://issues.apache.org/jira/browse/RANGER-4152
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Create common sub-module which will be responsible to handle/ incorporate common metrics in project. Individual sub-modules leveraging this common module, can have their specific metrics apart making it complete. Also add metrics in Ranger Admin.
> 
> 
> Diffs
> -----
> 
>   pom.xml 3a039565d 
>   ranger-metrics/.gitignore PRE-CREATION 
>   ranger-metrics/pom.xml PRE-CREATION 
>   ranger-metrics/src/main/java/org/apache/ranger/metrics/RangerMetricsInfo.java PRE-CREATION 
>   ranger-metrics/src/main/java/org/apache/ranger/metrics/RangerMetricsSystemWrapper.java PRE-CREATION 
>   ranger-metrics/src/main/java/org/apache/ranger/metrics/sink/RangerMetricsJsonSink.java PRE-CREATION 
>   ranger-metrics/src/main/java/org/apache/ranger/metrics/sink/RangerMetricsPrometheusSink.java PRE-CREATION 
>   ranger-metrics/src/main/java/org/apache/ranger/metrics/source/RangerMetricsJvmSource.java PRE-CREATION 
>   ranger-metrics/src/main/java/org/apache/ranger/metrics/source/RangerMetricsSource.java PRE-CREATION 
>   ranger-metrics/src/main/java/org/apache/ranger/metrics/wrapper/RangerMetricsSinkWrapper.java PRE-CREATION 
>   ranger-metrics/src/main/java/org/apache/ranger/metrics/wrapper/RangerMetricsSourceWrapper.java PRE-CREATION 
>   security-admin/pom.xml 2e5e21950 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 562467e80 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 455ae0bc4 
>   security-admin/src/main/java/org/apache/ranger/db/XXPortalUserDao.java 1787eeae6 
>   security-admin/src/main/java/org/apache/ranger/db/XXServiceDao.java 111c30d0d 
>   security-admin/src/main/java/org/apache/ranger/db/XXServiceDefDao.java ddf28f2e2 
>   security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 97bc2680a 
>   security-admin/src/main/java/org/apache/ranger/metrics/RangerAdminMetricsWrapper.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/metrics/RangerMetricsFetcher.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/metrics/source/RangerAdminMetricsSourceBase.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/metrics/source/RangerAdminMetricsSourceContextEnricher.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/metrics/source/RangerAdminMetricsSourceDenyConditions.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/metrics/source/RangerAdminMetricsSourcePolicyMasking.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/metrics/source/RangerAdminMetricsSourcePolicyResourceAccess.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/metrics/source/RangerAdminMetricsSourcePolicyRowFiltering.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/metrics/source/RangerAdminMetricsSourceService.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/metrics/source/RangerAdminMetricsSourceUserGroup.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/rest/MetricsREST.java e8e67c91d 
>   security-admin/src/main/java/org/apache/ranger/service/XGroupService.java 27651f312 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 1762d60c6 
>   security-admin/src/main/resources/conf.dist/security-applicationContext.xml 646da9d8c 
>   security-admin/src/main/resources/hadoop-metrics2.properties PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/74365/diff/3/
> 
> 
> Testing
> -------
> 
> 1. mvn clean compile package install
> 2. checked existing metrics APIs for any regression
> 3. verified new metrics API
> 
> 
> Thanks,
> 
> Kishor Gollapalliwar
> 
>