You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wetool19 (via GitHub)" <gi...@apache.org> on 2024/08/22 08:20:35 UTC
[PR] Nacos supports configuration context path [skywalking]
wetool19 opened a new pull request, #12558:
URL: https://github.com/apache/skywalking/pull/12558
Nacos supports configuration context path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Nacos supports configuration context path [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #12558:
URL: https://github.com/apache/skywalking/pull/12558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Nacos supports configuration context path [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #12558:
URL: https://github.com/apache/skywalking/pull/12558#issuecomment-2304072037
2 things you need to changs.
1. `application.yml` to adopt this change, and update `configuration-vocabulary.md` doc accordingly.
2. You should follow the template of pull request rather than ignoring it. CHANGES.md should be update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Nacos supports configuration context path [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12558:
URL: https://github.com/apache/skywalking/pull/12558#discussion_r1726668949
##########
docs/en/changes/changes.md:
##########
@@ -9,6 +9,7 @@
#### OAP Server
+* Nacos supports configuration contextPath.
Review Comment:
Please add to the latest line of this section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Nacos supports configuration context path [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12558:
URL: https://github.com/apache/skywalking/pull/12558#discussion_r1726669326
##########
docs/en/setup/backend/configuration-vocabulary.md:
##########
@@ -81,6 +81,7 @@ The Configuration Vocabulary lists all available configurations provided by `app
| - | - | namespace | Namespace used by SkyWalking node coordination. | SW_CLUSTER_NACOS_NAMESPACE | public |
| - | - | internalComHost | The hostname registered in Nacos for internal communications of the OAP cluster. | SW_CLUSTER_INTERNAL_COM_HOST | - |
| - | - | internalComPort | The port registered in Nacos for internal communications of the OAP cluster. | SW_CLUSTER_INTERNAL_COM_PORT | -1 |
+| - | - | contextPath | Nacos set contextPath. | SW_CLUSTER_NACOS_CONTEXT_PATH | - |
Review Comment:
Last of the Nacos part, please.
##########
docs/en/changes/changes.md:
##########
@@ -9,6 +9,7 @@
#### OAP Server
+* Nacos supports configuration contextPath.
Review Comment:
Please add to the last line of this section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Nacos supports configuration context path [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12558:
URL: https://github.com/apache/skywalking/pull/12558#discussion_r1726669326
##########
docs/en/setup/backend/configuration-vocabulary.md:
##########
@@ -81,6 +81,7 @@ The Configuration Vocabulary lists all available configurations provided by `app
| - | - | namespace | Namespace used by SkyWalking node coordination. | SW_CLUSTER_NACOS_NAMESPACE | public |
| - | - | internalComHost | The hostname registered in Nacos for internal communications of the OAP cluster. | SW_CLUSTER_INTERNAL_COM_HOST | - |
| - | - | internalComPort | The port registered in Nacos for internal communications of the OAP cluster. | SW_CLUSTER_INTERNAL_COM_PORT | -1 |
+| - | - | contextPath | Nacos set contextPath. | SW_CLUSTER_NACOS_CONTEXT_PATH | - |
Review Comment:
Last of the Nacos part, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org