You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "FlyingZC (via GitHub)" <gi...@apache.org> on 2023/07/13 06:24:58 UTC

[GitHub] [shardingsphere] FlyingZC opened a new issue, #27028: Support parsing Oracle CREATE INDEXTYPE sql

FlyingZC opened a new issue, #27028:
URL: https://github.com/apache/shardingsphere/issues/27028

   # Background
   Hi community,
   This issue is for #26878.
   
   ShardingSphere parser engine helps users parse a SQL to get the AST (Abstract Syntax Tree) and visit this tree to get SQLStatement (Java Object). Currently, we are planning to enhance the support for Oracle SQL parsing in ShardingSphere.
   
   More details:
   https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/
   
   # Task
   This issue is to support more oracle sql parse, as follows:
   ```sql
   CREATE INDEXTYPE TextIndexType
     FOR Contains (VARCHAR2, VARCHAR2)
     USING TextIndexMethods
     WITH LOCAL PARTITION
     WITH SYSTEM MANAGED STORAGE TABLES;
   ```
   
   ```sql
   CREATE INDEXTYPE position_indextype
      FOR position_between(NUMBER, NUMBER, NUMBER)
      USING position_im;
   ```
   
   ```sql
   CREATE JAVA CLASS USING BFILE (java_dir, 'Agent.class')
   ```
   
   ```sql
   CREATE JAVA CLASS USING BFILE (Bfile_dir, 'Agent.class');
   ```
   
   ```sql
   CREATE JAVA RESOURCE NAMED "appText" 
      USING BFILE (java_dir, 'textBundle.dat')
   ```
   
   # Process
   1. First confirm that this is a correct oracle sql syntax, if not please ignore;
   2. Compare SQL definitions in Oficial SQL Doc and ShardingSphere SQL Doc;
   3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
   4. Run mvn install the current_file_module;
   5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
   6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statment XML;
   7. Run SQLParserParameterizedTest to make sure no exceptions.
   
   # Relevant Skills
   1. Master JAVA language
   2. Have a basic understanding of Antlr `g4` file
   3. Be familiar with Oracle SQLs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle CREATE INDEXTYPE sql [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu closed issue #27028: Support parsing Oracle CREATE INDEXTYPE sql
URL: https://github.com/apache/shardingsphere/issues/27028


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] github-actions[bot] commented on issue #27028: Support parsing Oracle CREATE INDEXTYPE sql

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27028:
URL: https://github.com/apache/shardingsphere/issues/27028#issuecomment-1676081226

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle CREATE INDEXTYPE sql [shardingsphere]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27028:
URL: https://github.com/apache/shardingsphere/issues/27028#issuecomment-1785955191

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle CREATE INDEXTYPE sql [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on issue #27028:
URL: https://github.com/apache/shardingsphere/issues/27028#issuecomment-5329004662

   Hi @FlyingZC, thanks for raising this. Oracle `CREATE INDEXTYPE` parsing is now supported, so this issue can be closed as completed.
   
   `CREATE INDEXTYPE` support was merged in #39302, including the `createIndexType` grammar rule, the `OracleCreateIndexTypeStatement` AST node, visitor support, and parser test cases covering the examples in this issue (`WITH LOCAL PARTITION` and `WITH SYSTEM MANAGED STORAGE TABLES` variants). The `CREATE JAVA ... USING BFILE` statements listed here were already covered by #28652.
   
   Closing as completed. Feel free to reopen with a concrete SQL example if anything is still unparsed on the latest master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org