You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "smileby (via GitHub)" <gi...@apache.org> on 2023/12/31 14:03:34 UTC

[PR] feat: Add schema attribute definition for some log plug-ins [apisix]

smileby opened a new pull request, #10738:
URL: https://github.com/apache/apisix/pull/10738

   ### Description
   
   fixed #9190 
   
   Add schema attribute definition for some log plug-ins.
   
   schema attribute details as follows
   Add `include_req_body` and `include_req_body_expr` attributes to `file-logger`
   Add `include_req_body_expr` attributes to `http-logger`
   Add `include_req_body_expr` attributes to `loggly`
   Add `include_resp_body_expr` and `include_resp_body_expr` attributes to `tencent-cloud-cls`
   
   Fixes # (issue)
   
   ### Checklist
   
   - [X] I have explained the need for this PR and the problem it solves
   - [X] I have explained the changes or the new features added to this PR
   - [X] I have added tests corresponding to this change
   - [X] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Add schema attribute definition for some log plug-ins [apisix]

Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #10738:
URL: https://github.com/apache/apisix/pull/10738#issuecomment-1874174212

   It doesn't matter, the ci `CLI Test` fails occasionaly, we will fix it later


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Add schema attribute definition for some log plug-ins [apisix]

Posted by "smileby (via GitHub)" <gi...@apache.org>.
smileby commented on PR #10738:
URL: https://github.com/apache/apisix/pull/10738#issuecomment-1873551071

   I don’t understand why CLI Test reports an error，Can you help me.
   
   
   ```
   [ info ] stop -> [ Start ]
   /home/runner/work/apisix/apisix/bin/apisix stop
   /usr/local/openresty//luajit/bin/luajit ./apisix/cli/apisix.lua stop
   Error: nginx: [error] open() "/home/runner/work/apisix/apisix/logs/nginx.pid" failed (2: No such file or directory)
   [ info ] stop -> [ Done ]
   + git checkout conf/config.yaml
   Updated 0 paths from the index
   Error: Process completed with exit code 1.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Add schema attribute definition for some log plug-ins [apisix]

Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 merged PR #10738:
URL: https://github.com/apache/apisix/pull/10738


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org