You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2020/06/08 16:33:34 UTC
[native-toolchain-CR] IMPALA-9837: Switch to GCC 7.5
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15205
Change subject: IMPALA-9837: Switch to GCC 7.5
......................................................................
IMPALA-9837: Switch to GCC 7.5
This changes GCC from version 4.9.2 to 7.5.0. The libstdc++
ABI changed between 4.9.2, so packages compiled from this
version onward are not interchangeable with packages compiled
previously.
This also bumps the version of binutils from 2.26.1 to 2.28.
Now that the native toolchain is past the major C++11 ABI
change, it should be easier to explore using newer versions
of GCC. This adds standalone compilations of GCC 8.3 and
GCC 9.2.
Change-Id: Ia0a454c93a72b562ee46912cebbdc82b8b8375d2
---
M buildall.sh
M init.sh
M source/gcc/build.sh
3 files changed, 14 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/05/15205/2
--
To view, visit http://gerrit.cloudera.org:8080/15205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0a454c93a72b562ee46912cebbdc82b8b8375d2
Gerrit-Change-Number: 15205
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] IMPALA-9837: Switch to GCC 7.5
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15205 )
Change subject: IMPALA-9837: Switch to GCC 7.5
......................................................................
Patch Set 2:
> Oh I guess this is still a draft. Looks fine to me but I'll wait
> until it's public to +2
Oops, forgot to publish it. I may wait on merging this until I know the Impala change is going in.
--
To view, visit http://gerrit.cloudera.org:8080/15205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0a454c93a72b562ee46912cebbdc82b8b8375d2
Gerrit-Change-Number: 15205
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 16:35:28 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9837: Switch to GCC 7.5
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15205 )
Change subject: IMPALA-9837: Switch to GCC 7.5
......................................................................
Patch Set 2: Verified+1
I ran a build with the docker framework and used the resulting binaries for Impala, +1 verifying.
--
To view, visit http://gerrit.cloudera.org:8080/15205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0a454c93a72b562ee46912cebbdc82b8b8375d2
Gerrit-Change-Number: 15205
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jun 2020 23:41:23 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9837: Switch to GCC 7.5
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15205 )
Change subject: IMPALA-9837: Switch to GCC 7.5
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0a454c93a72b562ee46912cebbdc82b8b8375d2
Gerrit-Change-Number: 15205
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 21:57:02 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9837: Switch to GCC 7.5
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15205 )
Change subject: IMPALA-9837: Switch to GCC 7.5
......................................................................
IMPALA-9837: Switch to GCC 7.5
This changes GCC from version 4.9.2 to 7.5.0. The libstdc++
ABI changed between 4.9.2, so packages compiled from this
version onward are not interchangeable with packages compiled
previously.
This also bumps the version of binutils from 2.26.1 to 2.28.
Now that the native toolchain is past the major C++11 ABI
change, it should be easier to explore using newer versions
of GCC. This adds standalone compilations of GCC 8.3 and
GCC 9.2.
Change-Id: Ia0a454c93a72b562ee46912cebbdc82b8b8375d2
Reviewed-on: http://gerrit.cloudera.org:8080/15205
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M buildall.sh
M init.sh
M source/gcc/build.sh
3 files changed, 14 insertions(+), 3 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Joe McDonnell: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0a454c93a72b562ee46912cebbdc82b8b8375d2
Gerrit-Change-Number: 15205
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>