You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/06 20:56:45 UTC

[GitHub] [beam] udim commented on a change in pull request #11623: [BEAM-9908] Fix Python build failures in release script.

udim commented on a change in pull request #11623:
URL: https://github.com/apache/beam/pull/11623#discussion_r421086807



##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -275,7 +276,7 @@ if [[ $confirmation = "y" ]]; then
   git clone ${GIT_REPO_URL}
   cd ${BEAM_ROOT_DIR}
   git checkout ${RELEASE_BRANCH}
-  cd sdks/python && tox -e docs
+  cd sdks/python && pip install -r build-requirements.txt && tox -e py37-docs

Review comment:
       There are 2 virtualenvs here. The one in line 272 will use the default python version, and the one created by tox will use python3.7.
   Tox runs "python setup.py sdist" in the first virtualenv and installs the tarball in the second.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org