You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by "stefanseifert (via GitHub)" <gi...@apache.org> on 2024/12/17 10:28:10 UTC

[PR] SLING-12578 Fix Injector and Implementation Picker service ranking order again [sling-org-apache-sling-models-impl]

stefanseifert opened a new pull request, #64:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/64

   this actually reverts all implementation changes from the wrong bugfix SLING-12472, but keeps the added more fine-grained unit tests from it which check the correct order handling of Injector and ImplementationPickers in detail. additionally, we update to latest osgi-mock version to test the correct service list order.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SLING-12578 Fix Injector and Implementation Picker service ranking order again [sling-org-apache-sling-models-impl]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.

sonarcloud[bot] commented on PR #64:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/64#issuecomment-2548104232

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-impl&pullRequest=64) **Quality Gate failed**  
   Failed conditions  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [D Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-impl&pullRequest=64) (required ≥ A)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-impl&pullRequest=64)
   
   ##   
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png '') Catch issues before they fail your Quality Gate with our IDE extension ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png '') [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SLING-12578 Fix Injector and Implementation Picker service ranking order again [sling-org-apache-sling-models-impl]

Posted by "stefanseifert (via GitHub)" <gi...@apache.org>.

stefanseifert merged PR #64:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/64


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org