You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by rd...@apache.org on 2018/08/14 04:20:05 UTC
[incubator-pulsar] branch master updated: Set correct exception if
function runnable fails with Error (#2353)
This is an automated email from the ASF dual-hosted git repository.
rdhabalia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new c9988cf Set correct exception if function runnable fails with Error (#2353)
c9988cf is described below
commit c9988cff24aa12e94c2a09cd112ab2bfa0a8860b
Author: Rajan Dhabalia <rd...@apache.org>
AuthorDate: Mon Aug 13 21:20:02 2018 -0700
Set correct exception if function runnable fails with Error (#2353)
* Set correct exception if function runnable fails with Error
* fix throwable set
---
.../org/apache/pulsar/functions/instance/JavaInstanceRunnable.java | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java b/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
index aea9d53..fe94b17 100644
--- a/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
+++ b/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
@@ -185,8 +185,10 @@ public class JavaInstanceRunnable implements AutoCloseable, Runnable {
*/
@Override
public void run() {
+ String functionName = null;
try {
ContextImpl contextImpl = setupContext();
+ functionName = String.format("%s-%s", contextImpl.getTenant(), contextImpl.getFunctionName());
javaInstance = setupJavaInstance(contextImpl);
if (null != stateTable) {
StateContextImpl stateContext = new StateContextImpl(stateTable);
@@ -233,8 +235,8 @@ public class JavaInstanceRunnable implements AutoCloseable, Runnable {
}
}
} catch (Throwable t) {
- log.error("Uncaught exception in Java Instance", t);
- deathException = (Exception) t;
+ log.error("[{}] Uncaught exception in Java Instance", functionName, t);
+ deathException = t;
return;
} finally {
log.info("Closing instance");