[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1428: [CELEBORN-524][PERF] ChannelsLimiter onTrim add interval

["FMX (via GitHub)" <gi...@apache.org>]

FMX commented on code in PR #1428:
URL: https://github.com/apache/incubator-celeborn/pull/1428#discussion_r1169882680


##########
common/src/main/java/org/apache/celeborn/common/network/server/memory/MemoryManager.java:
##########
@@ -163,47 +161,33 @@ private MemoryManager(CelebornConf conf) {
                   "Memory manager actions transformed {} -> {}", lastAction, memoryManagerStat);
               if (memoryManagerStat == MemoryManagerStat.pausePushDataAndResumeReplicate) {
                 pausePushDataCounter.increment();
-                actionService.submit(

Review Comment:
   You have changed the memory check interval. This needs more tests to ensure stability.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org