[Bug 7151] New: lint does not detect extraneous pipe | symbol

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7151

            Bug ID: 7151
           Summary: lint does not detect extraneous pipe | symbol
           Product: Spamassassin
           Version: 3.3.1
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: spamassassin
          Assignee: dev@spamassassin.apache.org
          Reporter: vikigoyal@gmail.com

Hello,

I am running the following version of spamassassin:

[root@ spamassassin]# spamassassin -V
SpamAssassin version 3.3.1
  running on Perl version 5.10.1

[root@ spamassassin]# uname -a
Linux  2.6.32-504.1.3.el6.centos.plus.i686 #1 SMP Tue Nov 11 20:50:45 UTC 2014
i686 i686 i386 GNU/Linux

I am having a custom rule in my local file , as follows:

header __INS_SUB_5a         Subject =~
/.*((req|pl(s|ease))?\s.*approv(ing|al|e))\s.*((medi|insurance(\s|\-))?claim|).*/i

I checked the file with --lint but it did not detect extraneous | at the end of
rule. I remember once lint warning at such a mistake.

I don't know, maybe the lint behavior is correct but I thought to report it.

Kindly ignore it if it's not a bug & excuse for the noise.

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7151] lint does not detect extraneous pipe | symbol

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7151

--- Comment #2 from Mark Martinec <Ma...@ijs.si> ---
Nothing wrong with it, (a|b|c|) is equivalent to  (a|b|c)?

Btw, the .* at the beginning and end of your regexp are redundant.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7151] lint does not detect extraneous pipe | symbol

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7151

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
                 CC|                            |kmcgrail@pccc.com
             Status|NEW                         |RESOLVED

--- Comment #1 from Kevin A. McGrail <km...@pccc.com> ---
That's not an extraneous pipe.  It's a regex that has no parameters for
matching so I think it matches anything.  

In other words, you wrote a valid regex, it just is doubtful it does what you
wanted.

regards,
KAM

-- 
You are receiving this mail because:
You are the assignee for the bug.