You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/24 06:56:18 UTC

[GitHub] [apisix-dashboard] Gallardot opened a new issue #2342: Add view button for 'plugin-template/list' page

Gallardot opened a new issue #2342:
URL: https://github.com/apache/apisix-dashboard/issues/2342


   # Feature request
   
   ## Please describe your feature
   
   Many of the Dashboard's List pages have a View button that makes it easy to view detailed configuration information.
   I suggest adding a view button on the `plugin-template/list` page to view the details of the plugin-template configuration.
   
   ## Describe the solution you'd like
   
   A view button like any other List page will do.
   
   ## Describe alternatives you've considered
   
   None
   
   ## Additional context
   ![image](https://user-images.githubusercontent.com/329265/155473626-b95b41d1-9e14-4f62-8615-501d55432b9d.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] guoqqqi edited a comment on issue #2342: Add view button for `plugin-template/list` page

Posted by GitBox <gi...@apache.org>.
guoqqqi edited a comment on issue #2342:
URL: https://github.com/apache/apisix-dashboard/issues/2342#issuecomment-1076133017


   cc @Si-ege Can you help with this problem? We already have the relevant components in place, you can refer to the routing implementation https://github.com/apache/apisix-dashboard/blob/master/web/src/components/RawDataEditor/RawDataEditor.tsx 😄


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2342: Add view button for `plugin-template/list` page

Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on issue #2342:
URL: https://github.com/apache/apisix-dashboard/issues/2342#issuecomment-1049551709


   What is the difference in function and configuration buttons?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2342: Add view button for `plugin-template/list` page

Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on issue #2342:
URL: https://github.com/apache/apisix-dashboard/issues/2342#issuecomment-1049655127


   I'm not sure is there API support fetching row data of plugin-template configuration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] Gallardot commented on issue #2342: Add view button for `plugin-template/list` page

Posted by GitBox <gi...@apache.org>.
Gallardot commented on issue #2342:
URL: https://github.com/apache/apisix-dashboard/issues/2342#issuecomment-1049555507


   > What is the difference in function and configuration buttons?
   
   @Baoyuantop 
   
   Look like this, I want to be able to open a read-only Raw data editor.
   ![image](https://user-images.githubusercontent.com/329265/155475136-641740a1-7fbd-44ff-b97e-9b7da38e31ed.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] Gallardot edited a comment on issue #2342: Add view button for `plugin-template/list` page

Posted by GitBox <gi...@apache.org>.
Gallardot edited a comment on issue #2342:
URL: https://github.com/apache/apisix-dashboard/issues/2342#issuecomment-1050545358


   > I think the configure button can implement the function,even if it is not read-only
   
   @CP3cham 
   
   But the `configure button` and the `view button` have different semantic functions. And on the current implementation the `configure button` takes several actions to view the detailed configuration in the plug-in. The `view button` should provide a global view. This issue is just to improve user experience.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] Gallardot commented on issue #2342: Add view button for `plugin-template/list` page

Posted by GitBox <gi...@apache.org>.
Gallardot commented on issue #2342:
URL: https://github.com/apache/apisix-dashboard/issues/2342#issuecomment-1050545358


   > I think the configure button can implement the function,even if it is not read-only
   
   @CP3cham 
   
   But the `configure button` and the `view button` have different semantic functions.
   And on the current implementation the `configure button` takes several actions to view the detailed configuration in the plug-in.
   The `view button` should provide a global view.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] Si-ege commented on issue #2342: Add view button for `plugin-template/list` page

Posted by GitBox <gi...@apache.org>.
Si-ege commented on issue #2342:
URL: https://github.com/apache/apisix-dashboard/issues/2342#issuecomment-1076226509


   > cc @Si-ege Can you help with this problem? We already have the relevant components in place, you can refer to the routing implementation https://github.com/apache/apisix-dashboard/blob/master/web/src/components/RawDataEditor/RawDataEditor.tsx 😄
   
   I think I can


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] Si-ege commented on issue #2342: Add view button for `plugin-template/list` page

Posted by GitBox <gi...@apache.org>.
Si-ege commented on issue #2342:
URL: https://github.com/apache/apisix-dashboard/issues/2342#issuecomment-1077495514


   <img width="1671" alt="image" src="https://user-images.githubusercontent.com/92985804/159901257-0b037871-5b33-4ea1-b066-44ade921baf6.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] CP3cham commented on issue #2342: Add view button for `plugin-template/list` page

Posted by GitBox <gi...@apache.org>.
CP3cham commented on issue #2342:
URL: https://github.com/apache/apisix-dashboard/issues/2342#issuecomment-1050473699


   I think the configure button can  implement the function,even if it is not read-only


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] bzp2010 commented on issue #2342: Add view button for `plugin-template/list` page

Posted by GitBox <gi...@apache.org>.
bzp2010 commented on issue #2342:
URL: https://github.com/apache/apisix-dashboard/issues/2342#issuecomment-1053348382


   LGTM, if you have time, you can create a PR to complete it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] guoqqqi commented on issue #2342: Add view button for `plugin-template/list` page

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on issue #2342:
URL: https://github.com/apache/apisix-dashboard/issues/2342#issuecomment-1076133017


   cc @Si-ege Can you help with this problem? We already have the relevant components in place, you can refer to the routing implementation https://github.com/apache/apisix-dashboard/blob/master/web/src/components/RawDataEditor/RawDataEditor.tsx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org