You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yu-iskw <gi...@git.apache.org> on 2016/01/19 10:20:39 UTC
[GitHub] spark pull request: [SQL][Minor] DigestUtils.shaHex is deprecated ...
GitHub user yu-iskw opened a pull request:
https://github.com/apache/spark/pull/10831
[SQL][Minor] DigestUtils.shaHex is deprecated in misc.scala
Since `DigestUtils.shaHex` is deprecated, we should replace `shaHex` with `sha1Hex`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yu-iskw/spark minor-shaHex
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10831.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10831
----
commit ba303af06967a631aa4dc937b4ab354a6a578e86
Author: Yu ISHIKAWA <yu...@gmail.com>
Date: 2016-01-19T07:57:03Z
[SQL][Minor] DigestUtils.shaHex is deprecated
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SQL][Minor] DigestUtils.shaHex is deprecated ...
Posted by yu-iskw <gi...@git.apache.org>.
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/10831#issuecomment-172788036
@JoshRosen sorry, thank you for letting me know. I'll close this PR. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SQL][Minor] DigestUtils.shaHex is deprecated ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10831#issuecomment-172792245
**[Test build #49681 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49681/consoleFull)** for PR 10831 at commit [`ba303af`](https://github.com/apache/spark/commit/ba303af06967a631aa4dc937b4ab354a6a578e86).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SQL][Minor] DigestUtils.shaHex is deprecated ...
Posted by yu-iskw <gi...@git.apache.org>.
Github user yu-iskw closed the pull request at:
https://github.com/apache/spark/pull/10831
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SQL][Minor] DigestUtils.shaHex is deprecated ...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10831#issuecomment-172787455
This looks like a duplicate of #9532, FYI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SQL][Minor] DigestUtils.shaHex is deprecated ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10831#issuecomment-172800908
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49681/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SQL][Minor] DigestUtils.shaHex is deprecated ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10831#issuecomment-172800729
**[Test build #49681 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49681/consoleFull)** for PR 10831 at commit [`ba303af`](https://github.com/apache/spark/commit/ba303af06967a631aa4dc937b4ab354a6a578e86).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SQL][Minor] DigestUtils.shaHex is deprecated ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10831#issuecomment-172800904
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org