You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2017/04/03 09:19:38 UTC

[1/4] wicket git commit: WICKET-6351 Form.anyFormComponentError performance degradation

Repository: wicket
Updated Branches:
  refs/heads/master 7d7c3d928 -> f734ad676


WICKET-6351 Form.anyFormComponentError performance degradation


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/f734ad67
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/f734ad67
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/f734ad67

Branch: refs/heads/master
Commit: f734ad6764bc6c1c7bfc0fa09e85db27d7510d50
Parents: 9d18949
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Mon Apr 3 11:19:02 2017 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Mon Apr 3 11:19:31 2017 +0200

----------------------------------------------------------------------
 .../src/main/java/org/apache/wicket/markup/html/form/Form.java | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/f734ad67/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
index e8b61e7..a90ccc4 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
@@ -1028,8 +1028,7 @@ public class Form<T> extends WebMarkupContainer
 			public void component(final Component component, final IVisit<Void> visit)
 			{
 				Form<?> form = (Form<?>)component;
-				if (form.isEnabledInHierarchy() && form.isVisibleInHierarchy() &&
-					form.wantSubmitOnParentFormSubmit())
+				if (form.wantSubmitOnParentFormSubmit() && form.isEnabledInHierarchy() && form.isVisibleInHierarchy())
 				{
 					form.setFlag(FLAG_SUBMITTED, true);
 					return;
@@ -1171,8 +1170,7 @@ public class Form<T> extends WebMarkupContainer
 			@Override
 			public void component(final Component component, final IVisit<Boolean> visit)
 			{
-				if (component.isVisibleInHierarchy() && component.isEnabledInHierarchy() &&
-					component.hasErrorMessage())
+				if (component.hasErrorMessage() && component.isVisibleInHierarchy() && component.isEnabledInHierarchy())
 				{
 					visit.stop(true);
 				}


[2/4] wicket git commit: Update NPM and Nodejs

Posted by mg...@apache.org.
Update NPM and Nodejs


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/0a572bdf
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/0a572bdf
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/0a572bdf

Branch: refs/heads/master
Commit: 0a572bdf1dae0925b3082de85856d3971b7025b7
Parents: a6547ed
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Mon Apr 3 11:16:01 2017 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Mon Apr 3 11:19:31 2017 +0200

----------------------------------------------------------------------
 testing/wicket-js-tests/pom.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/0a572bdf/testing/wicket-js-tests/pom.xml
----------------------------------------------------------------------
diff --git a/testing/wicket-js-tests/pom.xml b/testing/wicket-js-tests/pom.xml
index 6b04681..ccbe44b 100644
--- a/testing/wicket-js-tests/pom.xml
+++ b/testing/wicket-js-tests/pom.xml
@@ -63,7 +63,7 @@
 					<plugin>
 						<groupId>com.github.eirslett</groupId>
 						<artifactId>frontend-maven-plugin</artifactId>
-						<version>1.3</version>
+						<version>1.4</version>
 						<executions>
 							<execution>
 								<id>install node and npm</id>
@@ -72,8 +72,8 @@
 								</goals>
 								<phase>generate-resources</phase>
 								<configuration>
-									<npmVersion>4.0.2</npmVersion>
-									<nodeVersion>v7.1.0</nodeVersion>
+									<npmVersion>4.4.4</npmVersion>
+									<nodeVersion>v7.8.0</nodeVersion>
 								</configuration>
 							</execution>
 							<execution>


[3/4] wicket git commit: Update Mockito to 2.7.21

Posted by mg...@apache.org.
Update Mockito to 2.7.21


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/9d189496
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/9d189496
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/9d189496

Branch: refs/heads/master
Commit: 9d18949626832b333540fd7315137154610c6ad4
Parents: 0a572bd
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Mon Apr 3 11:16:14 2017 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Mon Apr 3 11:19:31 2017 +0200

----------------------------------------------------------------------
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/9d189496/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 051ff8c..ba973ee 100644
--- a/pom.xml
+++ b/pom.xml
@@ -136,7 +136,7 @@
 		<servlet-api.version>3.1.0</servlet-api.version>
 		<maven.javadoc.version>2.10.4</maven.javadoc.version>
 		<maven.surefire.version>2.19.1</maven.surefire.version>
-		<mockito.version>2.7.19</mockito.version>
+		<mockito.version>2.7.21</mockito.version>
 		<slf4j.version>1.7.25</slf4j.version>
 		<log4j.version>2.8.1</log4j.version>
 		<hamcrest.version>2.0.0.0</hamcrest.version>


[4/4] wicket git commit: Fix typos in javadoc

Posted by mg...@apache.org.
Fix typos in javadoc


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/a6547edf
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/a6547edf
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/a6547edf

Branch: refs/heads/master
Commit: a6547edfab5d44e69ad10fc76affb730929501a3
Parents: 7d7c3d9
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Mon Apr 3 11:08:01 2017 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Mon Apr 3 11:19:31 2017 +0200

----------------------------------------------------------------------
 .../java/org/apache/wicket/resource/FileSystemResource.java  | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/a6547edf/wicket-core/src/main/java/org/apache/wicket/resource/FileSystemResource.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/resource/FileSystemResource.java b/wicket-core/src/main/java/org/apache/wicket/resource/FileSystemResource.java
index 6348316..b4b270e 100644
--- a/wicket-core/src/main/java/org/apache/wicket/resource/FileSystemResource.java
+++ b/wicket-core/src/main/java/org/apache/wicket/resource/FileSystemResource.java
@@ -31,7 +31,7 @@ import org.apache.wicket.request.resource.PartWriterCallback;
 /**
  * Used to provide resources based on the on Java NIO FileSystem API.<br>
  * <br>
- * For more information see {@link org.apache.wicket.markup.html.media.FileSystemResourceReference}
+ * For more information see {@link FileSystemResourceReference}
  * 
  * @author Tobias Soloschenko
  *
@@ -59,6 +59,7 @@ public class FileSystemResource extends AbstractResource
 	 */
 	public FileSystemResource()
 	{
+		this(null);
 	}
 
 	/**
@@ -67,7 +68,6 @@ public class FileSystemResource extends AbstractResource
 	@Override
 	protected ResourceResponse newResourceResponse(Attributes attributes)
 	{
-
 		return createResourceResponse(path);
 	}
 
@@ -103,7 +103,7 @@ public class FileSystemResource extends AbstractResource
 		catch (IOException e)
 		{
 			throw new WicketRuntimeException(
-				"An error occured while processing the media resource response", e);
+				"An error occurred while processing the media resource response", e);
 		}
 	}
 
@@ -125,7 +125,7 @@ public class FileSystemResource extends AbstractResource
 	 * 
 	 * @return the mime type to be used for the response
 	 * @throws IOException
-	 *             if the mime type could'nt be resoulved
+	 *             if the mime type couldn't be resolved
 	 */
 	protected String getMimeType() throws IOException
 	{