You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Marcell Ortutay (JIRA)" <ji...@apache.org> on 2018/03/29 06:42:00 UTC
[jira] [Created] (PHOENIX-4679) Exit build-proto.sh if not using
protoc v2.5.0
Marcell Ortutay created PHOENIX-4679:
----------------------------------------
Summary: Exit build-proto.sh if not using protoc v2.5.0
Key: PHOENIX-4679
URL: https://issues.apache.org/jira/browse/PHOENIX-4679
Project: Phoenix
Issue Type: Improvement
Reporter: Marcell Ortutay
If you use a version of protoc later than v2.5.0 to regenerate protobufs, you'll get a diff from the current protobuf generated code, even if you made no changes to the .proto files. I assume this is undesirable, so it would be nice if the build-proto.sh script warned people about this. The following check would do this:
{code:java}
if [[ `protoc --version` != *"2.5.0"* ]]; then
echo "Must use protoc version 2.5.0"
exit 1
fi
{code}
If this seems useful I can submit a PR to implement this
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)