You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/12 03:03:49 UTC
[GitHub] [incubator-seatunnel] leo65535 opened a new pull request #1025: [hotfix] Fix wrong params in flink batch template
leo65535 opened a new pull request #1025:
URL: https://github.com/apache/incubator-seatunnel/pull/1025
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[SeaTunnel #XXXX] [component] Title of the pull request", where *SeaTunnel #XXXX* should be replaced by the actual issue number.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
Some params in `flink.batch.conf.template` are deprecated, we need to update them.
https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-connectors/seatunnel-connector-flink-file/src/main/java/org/apache/seatunnel/flink/source/FileSource.java
```
2022-01-12 04:39:40,911 ERROR org.apache.seatunnel.Seatunnel - Plugin[org.apache.seatunnel.flink.source.FileSource] contains invalid config, error: please specify [path] as non-empty
```
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1025: [hotfix] Fix wrong params in flink batch template
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on pull request #1025:
URL: https://github.com/apache/incubator-seatunnel/pull/1025#issuecomment-1011747962
> > @leo65535 Please also update the documentation [FileSource](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/flink/configuration/source-plugins/File.md)
>
> I checked the `File.md`, there seems nothing need to be changed, correct me if wrong.
It seems unnecessary to write `schema = "text"` if `format.type` is `text`, Please check. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1025: [hotfix] Fix wrong params in flink batch template
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on pull request #1025:
URL: https://github.com/apache/incubator-seatunnel/pull/1025#issuecomment-1011850015
>
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1025: [hotfix] Fix wrong params in flink batch template
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1025:
URL: https://github.com/apache/incubator-seatunnel/pull/1025#issuecomment-1011823163
> > > @leo65535 Please also update the documentation [FileSource](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/flink/configuration/source-plugins/File.md)
> >
> >
> > I checked the `File.md`, there seems nothing need to be changed, correct me if wrong.
>
> It seems unnecessary to write `schema = "text"` if `format.type` is `text`, Please check. Thanks
No, we must use `schema`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1025: [hotfix] Fix wrong params in flink batch template
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1025:
URL: https://github.com/apache/incubator-seatunnel/pull/1025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on a change in pull request #1025: [hotfix] Fix wrong params in flink batch template
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on a change in pull request #1025:
URL: https://github.com/apache/incubator-seatunnel/pull/1025#discussion_r783093877
##########
File path: config/flink.batch.conf.template
##########
@@ -26,9 +26,10 @@ env {
source {
# This is a example input plugin **only for test and demonstrate the feature input plugin**
- FileSource{
- file.path = "hdfs://localhost:9000/output/text"
- source_format = "text"
+ FileSource {
+ path = "/opt/data.txt"
Review comment:
I think `path = "hdfs://localhost:9000/output/text"` will be better, this way can better distinguish local files from hdfs or other file system files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1025: [hotfix] Fix wrong params in flink batch template
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on pull request #1025:
URL: https://github.com/apache/incubator-seatunnel/pull/1025#issuecomment-1011072675
@leo65535 Please also update the documentation [FileSource](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/flink/configuration/source-plugins/File.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1025: [hotfix] Fix wrong params in flink batch template
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1025:
URL: https://github.com/apache/incubator-seatunnel/pull/1025#issuecomment-1011694828
> @leo65535 Please also update the documentation [FileSource](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/flink/configuration/source-plugins/File.md)
I checked the `File.md`, there seems nothing need to be changed, correct me if wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on a change in pull request #1025: [hotfix] Fix wrong params in flink batch template
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on a change in pull request #1025:
URL: https://github.com/apache/incubator-seatunnel/pull/1025#discussion_r783095944
##########
File path: config/flink.batch.conf.template
##########
@@ -26,9 +26,10 @@ env {
source {
# This is a example input plugin **only for test and demonstrate the feature input plugin**
- FileSource{
- file.path = "hdfs://localhost:9000/output/text"
- source_format = "text"
+ FileSource {
+ path = "/opt/data.txt"
+ format.type = "text"
+ schema = "text"
Review comment:
It seems unnecessary to write `schema = "text"` if `format.type` is `text`
```java
case "text":
TextRowInputFormat textInputFormat = new TextRowInputFormat(filePath);
inputFormat = textInputFormat;
break;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 edited a comment on pull request #1025: [hotfix] Fix wrong params in flink batch template
Posted by GitBox <gi...@apache.org>.
leo65535 edited a comment on pull request #1025:
URL: https://github.com/apache/incubator-seatunnel/pull/1025#issuecomment-1011823163
> > > @leo65535 Please also update the documentation [FileSource](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/flink/configuration/source-plugins/File.md)
> >
> >
> > I checked the `File.md`, there seems nothing need to be changed, correct me if wrong.
>
> It seems unnecessary to write `schema = "text"` if `format.type` is `text`, Please check. Thanks
No, we must use `schema`, shouldn't update the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on a change in pull request #1025: [hotfix] Fix wrong params in flink batch template
Posted by GitBox <gi...@apache.org>.
leo65535 commented on a change in pull request #1025:
URL: https://github.com/apache/incubator-seatunnel/pull/1025#discussion_r783583992
##########
File path: config/flink.batch.conf.template
##########
@@ -26,9 +26,10 @@ env {
source {
# This is a example input plugin **only for test and demonstrate the feature input plugin**
- FileSource{
- file.path = "hdfs://localhost:9000/output/text"
- source_format = "text"
+ FileSource {
+ path = "/opt/data.txt"
Review comment:
Make sense, thanks
##########
File path: config/flink.batch.conf.template
##########
@@ -26,9 +26,10 @@ env {
source {
# This is a example input plugin **only for test and demonstrate the feature input plugin**
- FileSource{
- file.path = "hdfs://localhost:9000/output/text"
- source_format = "text"
+ FileSource {
+ path = "/opt/data.txt"
+ format.type = "text"
+ schema = "text"
Review comment:
Make sense, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 edited a comment on pull request #1025: [hotfix] Fix wrong params in flink batch template
Posted by GitBox <gi...@apache.org>.
leo65535 edited a comment on pull request #1025:
URL: https://github.com/apache/incubator-seatunnel/pull/1025#issuecomment-1011823163
> > > @leo65535 Please also update the documentation [FileSource](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/flink/configuration/source-plugins/File.md)
> >
> >
> > I checked the `File.md`, there seems nothing need to be changed, correct me if wrong.
>
> It seems unnecessary to write `schema = "text"` if `format.type` is `text`, Please check. Thanks
No, we must use `schema`, shouldn't update the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1025: [hotfix] Fix wrong params in flink batch template
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on pull request #1025:
URL: https://github.com/apache/incubator-seatunnel/pull/1025#issuecomment-1011850282
> > > > @leo65535 Please also update the documentation [FileSource](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/flink/configuration/source-plugins/File.md)
> > >
> > >
> > > I checked the `File.md`, there seems nothing need to be changed, correct me if wrong.
> >
> >
> > It seems unnecessary to write `schema = "text"` if `format.type` is `text`, Please check. Thanks
>
> No, we must use `schema`, shouldn't update the doc.
>
> 
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu removed a comment on pull request #1025: [hotfix] Fix wrong params in flink batch template
Posted by GitBox <gi...@apache.org>.
wuchunfu removed a comment on pull request #1025:
URL: https://github.com/apache/incubator-seatunnel/pull/1025#issuecomment-1011850015
>
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org